[PR #3014] [MERGED] proto: DNSSEC verification tweaks #3490

New issue

Closed

opened 2026-03-16 11:46:36 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:46:36 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/3014
Author: @djc
Created: 5/26/2025
Status: ✅ Merged
Merged: 5/27/2025
Merged by: @djc

Base: main ← Head: nsec-tweaks

📝 Commits (10+)

666c8a4 proto: clean up formatting
5498f4e proto: localize single usage site function
ce54c6b proto: inline is_dnssec() function
2693716 proto: simplify DnsHandle bounds
a057286 proto: attach verify_response() to DnssecDnsHandle
5a59418 proto: attach verify_rrsets() to DnssecDnsHandle
5de4d60 proto: attach verify_rrset() to DnssecDnsHandle
eece0ba proto: attach verify_dnskey_rrset() to DnssecDnsHandle
8f8e80f proto: avoid cloning handle
6933a2d proto: attach verify_default_rrset() to DnssecDnsHandle

📊 Changes

2 files changed (+729 additions, -762 deletions)

View changed files

📝 crates/proto/src/dnssec/dnssec_dns_handle/mod.rs (+723 -762)
📝 crates/proto/src/error.rs (+6 -0)

📄 Description

From reviewing:

#2899

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/3014 **Author:** [@djc](https://github.com/djc) **Created:** 5/26/2025 **Status:** ✅ Merged **Merged:** 5/27/2025 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `nsec-tweaks` --- ### 📝 Commits (10+) - [`666c8a4`](https://github.com/hickory-dns/hickory-dns/commit/666c8a4f76e1dddde67b1cf89d38bc8e4911c2ba) proto: clean up formatting - [`5498f4e`](https://github.com/hickory-dns/hickory-dns/commit/5498f4e6e79e6eac6bedff207cf0ad1ee783f549) proto: localize single usage site function - [`ce54c6b`](https://github.com/hickory-dns/hickory-dns/commit/ce54c6b37951002599c2647bfcb30e2cea337d47) proto: inline is_dnssec() function - [`2693716`](https://github.com/hickory-dns/hickory-dns/commit/26937166f7381233420c483908ad8c130ba2c31e) proto: simplify DnsHandle bounds - [`a057286`](https://github.com/hickory-dns/hickory-dns/commit/a057286d84322b8bc2e1a5e02418f6e94c3f343c) proto: attach verify_response() to DnssecDnsHandle - [`5a59418`](https://github.com/hickory-dns/hickory-dns/commit/5a59418c1efb97f834a0a01bb8cc9f5967f49c6d) proto: attach verify_rrsets() to DnssecDnsHandle - [`5de4d60`](https://github.com/hickory-dns/hickory-dns/commit/5de4d60a1e687051e0c2373b59a7ceebd6f14fc4) proto: attach verify_rrset() to DnssecDnsHandle - [`eece0ba`](https://github.com/hickory-dns/hickory-dns/commit/eece0bab9e587e00b101238449f9fcae20e4386d) proto: attach verify_dnskey_rrset() to DnssecDnsHandle - [`8f8e80f`](https://github.com/hickory-dns/hickory-dns/commit/8f8e80f02b2785251a7d534a46aec64ad16264f0) proto: avoid cloning handle - [`6933a2d`](https://github.com/hickory-dns/hickory-dns/commit/6933a2d85fa72e53824e936ae490d852104f8055) proto: attach verify_default_rrset() to DnssecDnsHandle ### 📊 Changes **2 files changed** (+729 additions, -762 deletions) <details> <summary>View changed files</summary> 📝 `crates/proto/src/dnssec/dnssec_dns_handle/mod.rs` (+723 -762) 📝 `crates/proto/src/error.rs` (+6 -0) </details> ### 📄 Description From reviewing: - #2899 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>