[PR #3490] [MERGED] fix(server): use dep:rusqlite to suppress implicit rusqlite feature #3889

New issue

Closed

opened 2026-03-16 12:08:07 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 12:08:07 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/3490
Author: @jpds
Created: 3/10/2026
Status: ✅ Merged
Merged: 3/11/2026
Merged by: @djc

Base: main ← Head: fix-server-rusqlite-gate

📝 Commits (1)

5768e6f fix(server): use dep:rusqlite to suppress implicit rusqlite feature

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 crates/server/Cargo.toml (+1 -1)

📄 Description

hickory-server's sqlite feature enabled rusqlite without the dep: prefix, which created an implicit rusqlite feature. cargo-auditable would see the resulting --cfg 'feature="rusqlite"' and attempt to pass rusqlite as a feature to the root hickory-dns package, which uses dep:rusqlite and has no such implicit feature, causing cargo metadata to fail.

No code uses cfg(feature = "rusqlite") in either crate; all gating is done on cfg(feature = "sqlite"), so this is a no-op change in behaviour.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/3490 **Author:** [@jpds](https://github.com/jpds) **Created:** 3/10/2026 **Status:** ✅ Merged **Merged:** 3/11/2026 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `fix-server-rusqlite-gate` --- ### 📝 Commits (1) - [`5768e6f`](https://github.com/hickory-dns/hickory-dns/commit/5768e6fbace828b2c79308db40e0ae14d5d740c1) fix(server): use dep:rusqlite to suppress implicit rusqlite feature ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `crates/server/Cargo.toml` (+1 -1) </details> ### 📄 Description hickory-server's sqlite feature enabled rusqlite without the dep: prefix, which created an implicit rusqlite feature. cargo-auditable would see the resulting --cfg 'feature="rusqlite"' and attempt to pass rusqlite as a feature to the root hickory-dns package, which uses dep:rusqlite and has no such implicit feature, causing cargo metadata to fail. No code uses cfg(feature = "rusqlite") in either crate; all gating is done on cfg(feature = "sqlite"), so this is a no-op change in behaviour. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>