[PR #2236] [CLOSED] dns-test: let the caller pick the NameServer's FQDN #2899

New issue

Closed

opened 2026-03-16 11:14:09 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:14:09 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2236
Author: @japaric
Created: 6/12/2024
Status: ❌ Closed

Base: main ← Head: ja-dns-test-fixed-ns-name

📝 Commits (1)

3347b42 dns-test: let the caller pick the NameServer's FQDN

📊 Changes

15 files changed (+83 additions, -36 deletions)

View changed files

📝 conformance/packages/conformance-tests/src/name_server/rfc4035/section_3/section_3_1/section_3_1_1.rs (+2 -2)
📝 conformance/packages/conformance-tests/src/name_server/scenarios.rs (+1 -1)
📝 conformance/packages/conformance-tests/src/resolver/dns/scenarios.rs (+2 -2)
📝 conformance/packages/conformance-tests/src/resolver/dnssec/fixtures.rs (+2 -2)
📝 conformance/packages/conformance-tests/src/resolver/dnssec/rfc4035/section_3/section_3_1/section_3_1_4.rs (+1 -1)
📝 conformance/packages/conformance-tests/src/resolver/dnssec/rfc4035/section_3/section_3_2.rs (+3 -3)
📝 conformance/packages/conformance-tests/src/resolver/dnssec/rfc4035/section_3/section_3_2/section_3_2_2.rs (+1 -1)
📝 conformance/packages/conformance-tests/src/resolver/dnssec/rfc4035/section_4/section_4_1.rs (+1 -1)
📝 conformance/packages/conformance-tests/src/resolver/dnssec/scenarios/ede.rs (+1 -1)
📝 conformance/packages/conformance-tests/src/resolver/dnssec/scenarios/secure.rs (+1 -1)
📝 conformance/packages/dns-test/examples/explore.rs (+1 -1)
📝 conformance/packages/dns-test/src/name_server.rs (+46 -11)
📝 conformance/packages/dns-test/src/record.rs (+8 -0)
📝 conformance/packages/dns-test/src/resolver.rs (+3 -3)
📝 conformance/packages/dns-test/src/tshark.rs (+10 -6)

📄 Description

so far, the FQDN of the NameServer has been automatically generated based on a monotonically increasing counter.

to test NSEC3 functionality is preferable to fix the domain name to a known value. this is because the NSEC3 algorithm sorts records by their hashed domain names; and a name that's generated on the fly and changes on each invocation of the test will affect the order of the NSEC3 records.

if #2235 is not good enough we can land this more invasive change. until I heard back from @pvdrz I'm going to leave this as a draft

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2236 **Author:** [@japaric](https://github.com/japaric) **Created:** 6/12/2024 **Status:** ❌ Closed **Base:** `main` ← **Head:** `ja-dns-test-fixed-ns-name` --- ### 📝 Commits (1) - [`3347b42`](https://github.com/hickory-dns/hickory-dns/commit/3347b429f88a9433ea75914e8fbef68ccaf9d7c4) dns-test: let the caller pick the NameServer's FQDN ### 📊 Changes **15 files changed** (+83 additions, -36 deletions) <details> <summary>View changed files</summary> 📝 `conformance/packages/conformance-tests/src/name_server/rfc4035/section_3/section_3_1/section_3_1_1.rs` (+2 -2) 📝 `conformance/packages/conformance-tests/src/name_server/scenarios.rs` (+1 -1) 📝 `conformance/packages/conformance-tests/src/resolver/dns/scenarios.rs` (+2 -2) 📝 `conformance/packages/conformance-tests/src/resolver/dnssec/fixtures.rs` (+2 -2) 📝 `conformance/packages/conformance-tests/src/resolver/dnssec/rfc4035/section_3/section_3_1/section_3_1_4.rs` (+1 -1) 📝 `conformance/packages/conformance-tests/src/resolver/dnssec/rfc4035/section_3/section_3_2.rs` (+3 -3) 📝 `conformance/packages/conformance-tests/src/resolver/dnssec/rfc4035/section_3/section_3_2/section_3_2_2.rs` (+1 -1) 📝 `conformance/packages/conformance-tests/src/resolver/dnssec/rfc4035/section_4/section_4_1.rs` (+1 -1) 📝 `conformance/packages/conformance-tests/src/resolver/dnssec/scenarios/ede.rs` (+1 -1) 📝 `conformance/packages/conformance-tests/src/resolver/dnssec/scenarios/secure.rs` (+1 -1) 📝 `conformance/packages/dns-test/examples/explore.rs` (+1 -1) 📝 `conformance/packages/dns-test/src/name_server.rs` (+46 -11) 📝 `conformance/packages/dns-test/src/record.rs` (+8 -0) 📝 `conformance/packages/dns-test/src/resolver.rs` (+3 -3) 📝 `conformance/packages/dns-test/src/tshark.rs` (+10 -6) </details> ### 📄 Description so far, the FQDN of the NameServer has been automatically generated based on a monotonically increasing counter. to test NSEC3 functionality is preferable to fix the domain name to a known value. this is because the NSEC3 algorithm sorts records by their *hashed* domain names; and a name that's generated on the fly and changes on each invocation of the test will affect the order of the NSEC3 records. if #2235 is not good enough we can land this more invasive change. until I heard back from @pvdrz I'm going to leave this as a draft --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>