[PR #3001] [MERGED] Clean up some `large_enum_variants` warnings #3489

New issue

Closed

opened 2026-03-16 11:46:20 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:46:20 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/3001
Author: @djc
Created: 5/20/2025
Status: ✅ Merged
Merged: 5/20/2025
Merged by: @djc

Base: main ← Head: large-variants

📝 Commits (2)

0b9dd0d proto: remove dead mDNS support code
93b3ef1 server: drop unnecessary large_enum_variant suppressions

📊 Changes

2 files changed (+0 additions, -64 deletions)

View changed files

📝 crates/resolver/src/name_server/name_server_pool.rs (+0 -62)
📝 crates/server/src/authority/auth_lookup.rs (+0 -2)

📄 Description

See #2994. I haven't audited all of them yet, but this cleans some of them up.

I think most of these suppressions are pretty much fine, either because (a) there's only one instance of the enum anyway, or (b) they're shortlived (the Connect enums in -proto).

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/3001 **Author:** [@djc](https://github.com/djc) **Created:** 5/20/2025 **Status:** ✅ Merged **Merged:** 5/20/2025 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `large-variants` --- ### 📝 Commits (2) - [`0b9dd0d`](https://github.com/hickory-dns/hickory-dns/commit/0b9dd0d324f246378bc6b55ccf91becd4ddad81d) proto: remove dead mDNS support code - [`93b3ef1`](https://github.com/hickory-dns/hickory-dns/commit/93b3ef11a3ca18c02a948d18f5ec4e2d79e3fc6e) server: drop unnecessary large_enum_variant suppressions ### 📊 Changes **2 files changed** (+0 additions, -64 deletions) <details> <summary>View changed files</summary> 📝 `crates/resolver/src/name_server/name_server_pool.rs` (+0 -62) 📝 `crates/server/src/authority/auth_lookup.rs` (+0 -2) </details> ### 📄 Description See #2994. I haven't audited all of them yet, but this cleans some of them up. I think most of these suppressions are pretty much fine, either because (a) there's only one instance of the enum anyway, or (b) they're shortlived (the `Connect` enums in -proto). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>