[PR #3489] Fix wildcard synthesis #3885

New issue

Open

opened 2026-03-16 12:08:07 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 12:08:07 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/3489
Author: @Cyberax
Created: 3/9/2026
Status: 🔄 Open

Base: main ← Head: bug/submit-fix-wildcards

📝 Commits (1)

df81d23 Fix wildcard synthesis

📊 Changes

2 files changed (+203 additions, -54 deletions)

View changed files

📝 crates/server/src/store/in_memory/inner.rs (+78 -51)
📝 tests/integration-tests/tests/integration/rfc4592_tests.rs (+125 -3)

📄 Description

According to the RFC 4592 Section 2.2.1, the wildcards should not be expanded if there's any matching name for the query.

For example:

server A 1.2.3.4

catchall A    4.5.6.7
catchall AAAA 1::2

* CNAME catchall.yourdomain.net.

Before this change, the AAAA lookup for server.yourdomain.net resulted in it getting resolved to the catchall record.

AI disclosure: this code was written by me. AI was used to generate the test case and for basic autocompletion.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/3489 **Author:** [@Cyberax](https://github.com/Cyberax) **Created:** 3/9/2026 **Status:** 🔄 Open **Base:** `main` ← **Head:** `bug/submit-fix-wildcards` --- ### 📝 Commits (1) - [`df81d23`](https://github.com/hickory-dns/hickory-dns/commit/df81d23809287475221c06e6867988c195d69314) Fix wildcard synthesis ### 📊 Changes **2 files changed** (+203 additions, -54 deletions) <details> <summary>View changed files</summary> 📝 `crates/server/src/store/in_memory/inner.rs` (+78 -51) 📝 `tests/integration-tests/tests/integration/rfc4592_tests.rs` (+125 -3) </details> ### 📄 Description According to the RFC 4592 Section 2.2.1, the wildcards should not be expanded if there's any matching name for the query. For example: ``` server A 1.2.3.4 catchall A 4.5.6.7 catchall AAAA 1::2 * CNAME catchall.yourdomain.net. ``` Before this change, the `AAAA` lookup for `server.yourdomain.net` resulted in it getting resolved to the `catchall` record. AI disclosure: this code was written by me. AI was used to generate the test case and for basic autocompletion. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>