[PR #2922] [MERGED] Delete print statements dumping logs in tests #3427

New issue

Closed

opened 2026-03-16 11:43:05 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:43:05 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2922
Author: @divergentdave
Created: 4/10/2025
Status: ✅ Merged
Merged: 4/11/2025
Merged by: @djc

Base: main ← Head: david/conformance-cleanup-printing-logs

📝 Commits (1)

7e3c957 Delete print statements dumping logs in tests

📊 Changes

8 files changed (+4 additions, -41 deletions)

View changed files

📝 conformance/packages/conformance-tests/src/forwarder/dnssec/scenarios/bogus.rs (+1 -6)
📝 conformance/packages/conformance-tests/src/name_server/rfc5155.rs (+0 -3)
📝 conformance/packages/conformance-tests/src/resolver/dns/rfc1035/truncation.rs (+0 -4)
📝 conformance/packages/conformance-tests/src/resolver/dnssec/regression.rs (+0 -2)
📝 conformance/packages/conformance-tests/src/resolver/dnssec/scenarios/bogus.rs (+1 -13)
📝 conformance/packages/conformance-tests/src/resolver/dnssec/scenarios/insecure/deprecated_algorithm.rs (+1 -5)
📝 conformance/packages/conformance-tests/src/resolver/dnssec/scenarios/nsec3/does_not_cover/mod.rs (+1 -6)
📝 tests/e2e-tests/src/resolver/do_not_query.rs (+0 -2)

📄 Description

This deletes several println!() calls throughout the conformance test suite that dump logs from servers. These are only really needed when debugging, and very easy to add back. This is primarily annoying when running just conformance-ignored, since the server logs make the output of that recipe far longer.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2922 **Author:** [@divergentdave](https://github.com/divergentdave) **Created:** 4/10/2025 **Status:** ✅ Merged **Merged:** 4/11/2025 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `david/conformance-cleanup-printing-logs` --- ### 📝 Commits (1) - [`7e3c957`](https://github.com/hickory-dns/hickory-dns/commit/7e3c957e9fc6f3c87a128862328d2c0e1f37760f) Delete print statements dumping logs in tests ### 📊 Changes **8 files changed** (+4 additions, -41 deletions) <details> <summary>View changed files</summary> 📝 `conformance/packages/conformance-tests/src/forwarder/dnssec/scenarios/bogus.rs` (+1 -6) 📝 `conformance/packages/conformance-tests/src/name_server/rfc5155.rs` (+0 -3) 📝 `conformance/packages/conformance-tests/src/resolver/dns/rfc1035/truncation.rs` (+0 -4) 📝 `conformance/packages/conformance-tests/src/resolver/dnssec/regression.rs` (+0 -2) 📝 `conformance/packages/conformance-tests/src/resolver/dnssec/scenarios/bogus.rs` (+1 -13) 📝 `conformance/packages/conformance-tests/src/resolver/dnssec/scenarios/insecure/deprecated_algorithm.rs` (+1 -5) 📝 `conformance/packages/conformance-tests/src/resolver/dnssec/scenarios/nsec3/does_not_cover/mod.rs` (+1 -6) 📝 `tests/e2e-tests/src/resolver/do_not_query.rs` (+0 -2) </details> ### 📄 Description This deletes several `println!()` calls throughout the conformance test suite that dump logs from servers. These are only really needed when debugging, and very easy to add back. This is primarily annoying when running `just conformance-ignored`, since the server logs make the output of that recipe far longer. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>