[PR #3427] proto: add extra diagnostics to tsig response validation errors #3837

New issue

Open

opened 2026-03-16 12:05:24 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 12:05:24 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/3427
Author: @jcgruenhage
Created: 1/7/2026
Status: 🔄 Open

Base: main ← Head: jc-gruenhage_data/jj/push-zltpuvsqprzp

📝 Commits (1)

dcd4dff proto: add extra diagnostics to tsig response validation errors

📊 Changes

1 file changed (+21 additions, -1 deletions)

View changed files

📝 crates/proto/src/dnssec/tsig.rs (+21 -1)

📄 Description

I ran into https://github.com/hickory-dns/hickory-dns/issues/1981 a second time in another context. We're still returning a protocol error here, so I'm not sure this is a solution - protocol error on an RFC conform response feels a bit off, but with the additional details included in the error message it's clearer what's going on.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/3427 **Author:** [@jcgruenhage](https://github.com/jcgruenhage) **Created:** 1/7/2026 **Status:** 🔄 Open **Base:** `main` ← **Head:** `jc-gruenhage_data/jj/push-zltpuvsqprzp` --- ### 📝 Commits (1) - [`dcd4dff`](https://github.com/hickory-dns/hickory-dns/commit/dcd4dff389b3b524b88033b894e9db8c676374ce) proto: add extra diagnostics to tsig response validation errors ### 📊 Changes **1 file changed** (+21 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `crates/proto/src/dnssec/tsig.rs` (+21 -1) </details> ### 📄 Description I ran into https://github.com/hickory-dns/hickory-dns/issues/1981 a second time in another context. We're still returning a protocol error here, so I'm not sure this is a solution - protocol error on an RFC conform response feels a bit off, but with the additional details included in the error message it's clearer what's going on. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>