[PR #2271] [MERGED] DnssecDnsHandle: do not recurse infinitely when query `DS .` fails #2922

New issue

Closed

opened 2026-03-16 11:15:31 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:15:31 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2271
Author: @japaric
Created: 7/2/2024
Status: ✅ Merged
Merged: 7/8/2024
Merged by: @djc

Base: main ← Head: ja-gh2252

📝 Commits (5)

0cfad33 dns-test: prepare API for configurable signing settings
2087ace add Implementation::hickory
f9ba99a minimal e2e test suite
4ade86b add regression test for issue #2252
957ad75 DnssecDnsHandle: do not recurse infinitely when query DS . fails

📊 Changes

23 files changed (+961 additions, -70 deletions)

View changed files

📝 .github/workflows/conformance.yml (+3 -0)
📝 conformance/packages/conformance-tests/src/name_server/rfc4035/section_3/section_3_1/section_3_1_1.rs (+3 -3)
📝 conformance/packages/conformance-tests/src/name_server/rfc5155.rs (+2 -2)
📝 conformance/packages/conformance-tests/src/resolver/dnssec/fixtures.rs (+26 -17)
📝 conformance/packages/conformance-tests/src/resolver/dnssec/rfc4035/section_3/section_3_1/section_3_1_4.rs (+7 -2)
📝 conformance/packages/conformance-tests/src/resolver/dnssec/rfc4035/section_3/section_3_2.rs (+6 -6)
📝 conformance/packages/conformance-tests/src/resolver/dnssec/rfc4035/section_4/section_4_5.rs (+3 -3)
📝 conformance/packages/conformance-tests/src/resolver/dnssec/scenarios/ede.rs (+7 -4)
📝 conformance/packages/conformance-tests/src/resolver/dnssec/scenarios/secure.rs (+2 -2)
📝 conformance/packages/dns-test/examples/explore.rs (+8 -2)
📝 conformance/packages/dns-test/src/implementation.rs (+10 -0)
📝 conformance/packages/dns-test/src/lib.rs (+0 -1)
📝 conformance/packages/dns-test/src/name_server.rs (+69 -25)
📝 conformance/packages/dns-test/src/resolver.rs (+2 -2)
📝 crates/proto/src/xfer/dnssec_dns_handle.rs (+12 -1)
📝 justfile (+27 -0)
➕ tests/e2e-tests/Cargo.lock (+676 -0)
➕ tests/e2e-tests/Cargo.toml (+12 -0)
➕ tests/e2e-tests/README.md (+7 -0)
➕ tests/e2e-tests/src/lib.rs (+16 -0)

...and 3 more files

📄 Description

fixes #2252

this PR depends on #2253 so its base has been set to that PR's branch. this PR will remain in draft state until that PR is merged.

this PR also crates a e2e-tests test suite where hickory-exclusive tests based on dns-test can reside. those tests won't run against unbound or BIND so it's a good place to put regression tests and tests that exercise hickory-exclusive features

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2271 **Author:** [@japaric](https://github.com/japaric) **Created:** 7/2/2024 **Status:** ✅ Merged **Merged:** 7/8/2024 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `ja-gh2252` --- ### 📝 Commits (5) - [`0cfad33`](https://github.com/hickory-dns/hickory-dns/commit/0cfad3348fc48b59296a7dfcdd305571273cbdd1) dns-test: prepare API for configurable signing settings - [`2087ace`](https://github.com/hickory-dns/hickory-dns/commit/2087acee2e7de80610c7eab8c3da3fddb3e64706) add Implementation::hickory - [`f9ba99a`](https://github.com/hickory-dns/hickory-dns/commit/f9ba99a1e02c50acdf22320e09dc3f3898f133b1) minimal e2e test suite - [`4ade86b`](https://github.com/hickory-dns/hickory-dns/commit/4ade86b1fa81fa6a0b6254024be211925ae0d888) add regression test for issue #2252 - [`957ad75`](https://github.com/hickory-dns/hickory-dns/commit/957ad75d31f32d9b06e90b3885f955da10bf3284) DnssecDnsHandle: do not recurse infinitely when query `DS .` fails ### 📊 Changes **23 files changed** (+961 additions, -70 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/conformance.yml` (+3 -0) 📝 `conformance/packages/conformance-tests/src/name_server/rfc4035/section_3/section_3_1/section_3_1_1.rs` (+3 -3) 📝 `conformance/packages/conformance-tests/src/name_server/rfc5155.rs` (+2 -2) 📝 `conformance/packages/conformance-tests/src/resolver/dnssec/fixtures.rs` (+26 -17) 📝 `conformance/packages/conformance-tests/src/resolver/dnssec/rfc4035/section_3/section_3_1/section_3_1_4.rs` (+7 -2) 📝 `conformance/packages/conformance-tests/src/resolver/dnssec/rfc4035/section_3/section_3_2.rs` (+6 -6) 📝 `conformance/packages/conformance-tests/src/resolver/dnssec/rfc4035/section_4/section_4_5.rs` (+3 -3) 📝 `conformance/packages/conformance-tests/src/resolver/dnssec/scenarios/ede.rs` (+7 -4) 📝 `conformance/packages/conformance-tests/src/resolver/dnssec/scenarios/secure.rs` (+2 -2) 📝 `conformance/packages/dns-test/examples/explore.rs` (+8 -2) 📝 `conformance/packages/dns-test/src/implementation.rs` (+10 -0) 📝 `conformance/packages/dns-test/src/lib.rs` (+0 -1) 📝 `conformance/packages/dns-test/src/name_server.rs` (+69 -25) 📝 `conformance/packages/dns-test/src/resolver.rs` (+2 -2) 📝 `crates/proto/src/xfer/dnssec_dns_handle.rs` (+12 -1) 📝 `justfile` (+27 -0) ➕ `tests/e2e-tests/Cargo.lock` (+676 -0) ➕ `tests/e2e-tests/Cargo.toml` (+12 -0) ➕ `tests/e2e-tests/README.md` (+7 -0) ➕ `tests/e2e-tests/src/lib.rs` (+16 -0) _...and 3 more files_ </details> ### 📄 Description fixes #2252 this PR depends on #2253 so its base has been set to that PR's branch. this PR will remain in draft state until that PR is merged. this PR also crates a `e2e-tests` test suite where hickory-exclusive tests based on `dns-test` can reside. those tests won't run against `unbound` or BIND so it's a good place to put regression tests and tests that exercise hickory-exclusive features --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>