[PR #2900] [MERGED] Add more server metrics and enhance existing metrics #3411

New issue

Closed

opened 2026-03-16 11:42:16 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:42:16 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2900
Author: @hargut
Created: 4/2/2025
Status: ✅ Merged
Merged: 4/29/2025
Merged by: @djc

Base: main ← Head: feat/add-more-metrics

📝 Commits (8)

64c5371 recursor, resolver: use dependency version from workspace
a10cbe2 bin: add process, config and metadata metrics
3a0a3ac server: refine query store metrics
4fa436b server: prepare for refined dynamic updated metrics
9982b50 server: add refined dynamic update metrics
cd58093 server: add request, response metrics
723cc8b server: add option to skip file store metric init
e0f05e3 bin: add metric tests

📊 Changes

16 files changed (+1553 additions, -72 deletions)

View changed files

📝 Cargo.lock (+359 -5)
📝 Cargo.toml (+4 -0)
📝 bin/Cargo.toml (+7 -1)
📝 bin/src/hickory-dns.rs (+160 -1)
📝 bin/tests/integration/main.rs (+2 -0)
➕ bin/tests/integration/named_metrics_tests.rs (+510 -0)
📝 bin/tests/integration/server_harness/mod.rs (+25 -8)
📝 crates/recursor/Cargo.toml (+1 -1)
📝 crates/resolver/Cargo.toml (+1 -1)
➕ crates/server/src/server/metrics.rs (+273 -0)
📝 crates/server/src/server/mod.rs (+31 -0)
📝 crates/server/src/server/response_handler.rs (+1 -1)
📝 crates/server/src/store/file.rs (+49 -13)
📝 crates/server/src/store/forwarder.rs (+1 -1)
📝 crates/server/src/store/metrics.rs (+80 -17)
📝 crates/server/src/store/sqlite/mod.rs (+49 -23)

📄 Description

This PR adds more https://github.com/hickory-dns/hickory-dns/issues/2032 and enhances existing metrics (https://github.com/hickory-dns/hickory-dns/pull/2886).

The following areas are covered:

process metrics
hickory & config metadata
request / response metrics
refined dynamic record update metrics
refined store lookup metrics

Kind regards,
Harald

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2900 **Author:** [@hargut](https://github.com/hargut) **Created:** 4/2/2025 **Status:** ✅ Merged **Merged:** 4/29/2025 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `feat/add-more-metrics` --- ### 📝 Commits (8) - [`64c5371`](https://github.com/hickory-dns/hickory-dns/commit/64c537156c1cdeb0a39ceb38f791f1759fec3145) recursor, resolver: use dependency version from workspace - [`a10cbe2`](https://github.com/hickory-dns/hickory-dns/commit/a10cbe24eae75727e9e92885b94d96e8a94a1455) bin: add process, config and metadata metrics - [`3a0a3ac`](https://github.com/hickory-dns/hickory-dns/commit/3a0a3ac1040d110f286fe31e67ff228fda694058) server: refine query store metrics - [`4fa436b`](https://github.com/hickory-dns/hickory-dns/commit/4fa436b13e6a3801cbf3fcc9253b3f4d617ef003) server: prepare for refined dynamic updated metrics - [`9982b50`](https://github.com/hickory-dns/hickory-dns/commit/9982b5016cf848cd20c9b42d84266bb5eb53913d) server: add refined dynamic update metrics - [`cd58093`](https://github.com/hickory-dns/hickory-dns/commit/cd58093121f6b8ec5488c937e7563b19147a90a6) server: add request, response metrics - [`723cc8b`](https://github.com/hickory-dns/hickory-dns/commit/723cc8b99c3a6bf926088ecdf6d761a9d6a8303e) server: add option to skip file store metric init - [`e0f05e3`](https://github.com/hickory-dns/hickory-dns/commit/e0f05e3a09b876e59906921ffd0f7e6048962204) bin: add metric tests ### 📊 Changes **16 files changed** (+1553 additions, -72 deletions) <details> <summary>View changed files</summary> 📝 `Cargo.lock` (+359 -5) 📝 `Cargo.toml` (+4 -0) 📝 `bin/Cargo.toml` (+7 -1) 📝 `bin/src/hickory-dns.rs` (+160 -1) 📝 `bin/tests/integration/main.rs` (+2 -0) ➕ `bin/tests/integration/named_metrics_tests.rs` (+510 -0) 📝 `bin/tests/integration/server_harness/mod.rs` (+25 -8) 📝 `crates/recursor/Cargo.toml` (+1 -1) 📝 `crates/resolver/Cargo.toml` (+1 -1) ➕ `crates/server/src/server/metrics.rs` (+273 -0) 📝 `crates/server/src/server/mod.rs` (+31 -0) 📝 `crates/server/src/server/response_handler.rs` (+1 -1) 📝 `crates/server/src/store/file.rs` (+49 -13) 📝 `crates/server/src/store/forwarder.rs` (+1 -1) 📝 `crates/server/src/store/metrics.rs` (+80 -17) 📝 `crates/server/src/store/sqlite/mod.rs` (+49 -23) </details> ### 📄 Description This PR adds more https://github.com/hickory-dns/hickory-dns/issues/2032 and enhances existing metrics (https://github.com/hickory-dns/hickory-dns/pull/2886). The following areas are covered: - process metrics - hickory & config metadata - request / response metrics - refined dynamic record update metrics - refined store lookup metrics Kind regards, Harald --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>