[PR #3415] [MERGED] bin: drop server before trying to do cleanup #3820

New issue

Closed

opened 2026-03-16 12:04:35 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 12:04:35 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/3415
Author: @djc
Created: 12/21/2025
Status: ✅ Merged
Merged: 12/21/2025
Merged by: @djc

Base: main ← Head: test-server-cleanup

📝 Commits (1)

535b83b bin: drop server before trying to do cleanup

📊 Changes

1 file changed (+1 additions, -0 deletions)

View changed files

📝 bin/tests/integration/named_metrics_tests.rs (+1 -0)

📄 Description

test_updates has been failing (intermittently?), presumably since

#3411

which has this test trying to clean up before the test server is actually gone (still in scope):

thread 'named_metrics_tests::test_updates' (1264) panicked at bin\tests\integration\named_metrics_tests.rs:602:32:
failed to cleanup after test: Os { code: 32, kind: Uncategorized, message: "The process cannot access the file because it is being used by another process." }

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/3415 **Author:** [@djc](https://github.com/djc) **Created:** 12/21/2025 **Status:** ✅ Merged **Merged:** 12/21/2025 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `test-server-cleanup` --- ### 📝 Commits (1) - [`535b83b`](https://github.com/hickory-dns/hickory-dns/commit/535b83b316ce5e6b2df5a74e65033e685c5950dd) bin: drop server before trying to do cleanup ### 📊 Changes **1 file changed** (+1 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `bin/tests/integration/named_metrics_tests.rs` (+1 -0) </details> ### 📄 Description `test_updates` has been failing (intermittently?), presumably since - #3411 which has this test trying to clean up before the test server is actually gone (still in scope): ``` thread 'named_metrics_tests::test_updates' (1264) panicked at bin\tests\integration\named_metrics_tests.rs:602:32: failed to cleanup after test: Os { code: 32, kind: Uncategorized, message: "The process cannot access the file because it is being used by another process." } ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>