[PR #2898] [MERGED] Store CAA value as raw bytes #3406

New issue

Closed

opened 2026-03-16 11:42:00 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:42:00 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2898
Author: @divergentdave
Created: 4/1/2025
Status: ✅ Merged
Merged: 4/7/2025
Merged by: @djc

Base: main ← Head: david/caa-raw-value

📝 Commits (2)

e4e4b4e Use read_value in presentation format parser
0d51e9b Also store CAA value as raw bytes

📊 Changes

4 files changed (+104 additions, -62 deletions)

View changed files

📝 bin/tests/integration/txt_tests.rs (+3 -1)
📝 conformance/packages/conformance-tests/src/resolver/dns/rfc3597.rs (+0 -1)
📝 crates/proto/src/rr/rdata/caa.rs (+89 -42)
📝 crates/proto/src/serialize/txt/rdata_parsers/caa.rs (+12 -18)

📄 Description

This changes the CAA struct to store the value as-is, and defer interpreting the value as either a URL or name plus parameters. This closes #1353 and fixes some fuzzer failures.

Note that previously, emit_value() and <Value as Display>::fmt() encoded empty issue/issuewild values differently, as either "" or ";". After this PR, there is only one encoding routine, used in the convenience constructors. As a result, some of the expected values in .to_string() tests have changed.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2898 **Author:** [@divergentdave](https://github.com/divergentdave) **Created:** 4/1/2025 **Status:** ✅ Merged **Merged:** 4/7/2025 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `david/caa-raw-value` --- ### 📝 Commits (2) - [`e4e4b4e`](https://github.com/hickory-dns/hickory-dns/commit/e4e4b4e5cb232147105247ba825c24b5b821a85a) Use read_value in presentation format parser - [`0d51e9b`](https://github.com/hickory-dns/hickory-dns/commit/0d51e9ba51405aa43c528ac5352de016a44c4da6) Also store CAA value as raw bytes ### 📊 Changes **4 files changed** (+104 additions, -62 deletions) <details> <summary>View changed files</summary> 📝 `bin/tests/integration/txt_tests.rs` (+3 -1) 📝 `conformance/packages/conformance-tests/src/resolver/dns/rfc3597.rs` (+0 -1) 📝 `crates/proto/src/rr/rdata/caa.rs` (+89 -42) 📝 `crates/proto/src/serialize/txt/rdata_parsers/caa.rs` (+12 -18) </details> ### 📄 Description This changes the CAA struct to store the value as-is, and defer interpreting the value as either a URL or name plus parameters. This closes #1353 and fixes some fuzzer failures. Note that previously, `emit_value()` and `<Value as Display>::fmt()` encoded empty `issue`/`issuewild` values differently, as either `""` or `";"`. After this PR, there is only one encoding routine, used in the convenience constructors. As a result, some of the expected values in `.to_string()` tests have changed. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>