[PR #296] [MERGED] add rustfmt to CI #1353

New issue

Closed

opened 2026-03-16 02:01:53 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 02:01:53 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/296
Author: @little-dude
Created: 11/25/2017
Status: ✅ Merged
Merged: 11/27/2017
Merged by: @bluejekyll

Base: master ← Head: rustfmt

📝 Commits (6)

10106ee add jobs for rustfmt and clippy
0d86f6a add rustfmt config
dd93cdc rustfmt
a954776 Merge branch 'master' into rustfmt
e09ce8d merge upstream changes
d5b523d allow rustfmt failures

📊 Changes

136 files changed (+3307 additions, -3223 deletions)

View changed files

➕ .rustfmt.toml (+3 -0)
📝 .travis.yml (+14 -3)
📝 client/src/client/client.rs (+55 -61)
📝 client/src/client/client_connection.rs (+9 -1)
📝 client/src/client/client_future.rs (+10 -4)
📝 client/src/client/mod.rs (+2 -2)
📝 client/src/client/rc_future.rs (+13 -9)
📝 client/src/lib.rs (+2 -2)
📝 client/src/op/update_message.rs (+1 -1)
📝 client/src/rr/dnssec/key_format.rs (+48 -65)
📝 client/src/rr/dnssec/keypair.rs (+41 -67)
📝 client/src/rr/dnssec/signer.rs (+7 -8)
📝 client/src/serialize/txt/master.rs (+38 -36)
📝 client/src/serialize/txt/master_lex.rs (+108 -126)
📝 client/src/serialize/txt/rdata_parsers/a.rs (+7 -8)
📝 client/src/serialize/txt/rdata_parsers/aaaa.rs (+7 -8)
📝 client/src/serialize/txt/rdata_parsers/caa.rs (+12 -12)
📝 client/src/serialize/txt/rdata_parsers/mx.rs (+6 -4)
📝 client/src/serialize/txt/rdata_parsers/name.rs (+4 -5)
📝 client/src/serialize/txt/rdata_parsers/null.rs (+1 -1)

...and 80 more files

📄 Description

This PR add a rustfmt job that fails when the code is not formatted with rustfmt.
Fix https://github.com/bluejekyll/trust-dns/issues/293

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/296 **Author:** [@little-dude](https://github.com/little-dude) **Created:** 11/25/2017 **Status:** ✅ Merged **Merged:** 11/27/2017 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `master` ← **Head:** `rustfmt` --- ### 📝 Commits (6) - [`10106ee`](https://github.com/hickory-dns/hickory-dns/commit/10106eee4fe92778f91cfe3b1dadf181e068718f) add jobs for rustfmt and clippy - [`0d86f6a`](https://github.com/hickory-dns/hickory-dns/commit/0d86f6a4cde601a924da177e53f23f471a6ce987) add rustfmt config - [`dd93cdc`](https://github.com/hickory-dns/hickory-dns/commit/dd93cdc309759734f400cff0868b9da185881783) rustfmt - [`a954776`](https://github.com/hickory-dns/hickory-dns/commit/a954776a8f4746bff4413f3e19eb57314805eef2) Merge branch 'master' into rustfmt - [`e09ce8d`](https://github.com/hickory-dns/hickory-dns/commit/e09ce8deb93ec0eb08a4d341bbde92c2687101ee) merge upstream changes - [`d5b523d`](https://github.com/hickory-dns/hickory-dns/commit/d5b523dec29af67b8a42aecb686dd7b2df544011) allow rustfmt failures ### 📊 Changes **136 files changed** (+3307 additions, -3223 deletions) <details> <summary>View changed files</summary> ➕ `.rustfmt.toml` (+3 -0) 📝 `.travis.yml` (+14 -3) 📝 `client/src/client/client.rs` (+55 -61) 📝 `client/src/client/client_connection.rs` (+9 -1) 📝 `client/src/client/client_future.rs` (+10 -4) 📝 `client/src/client/mod.rs` (+2 -2) 📝 `client/src/client/rc_future.rs` (+13 -9) 📝 `client/src/lib.rs` (+2 -2) 📝 `client/src/op/update_message.rs` (+1 -1) 📝 `client/src/rr/dnssec/key_format.rs` (+48 -65) 📝 `client/src/rr/dnssec/keypair.rs` (+41 -67) 📝 `client/src/rr/dnssec/signer.rs` (+7 -8) 📝 `client/src/serialize/txt/master.rs` (+38 -36) 📝 `client/src/serialize/txt/master_lex.rs` (+108 -126) 📝 `client/src/serialize/txt/rdata_parsers/a.rs` (+7 -8) 📝 `client/src/serialize/txt/rdata_parsers/aaaa.rs` (+7 -8) 📝 `client/src/serialize/txt/rdata_parsers/caa.rs` (+12 -12) 📝 `client/src/serialize/txt/rdata_parsers/mx.rs` (+6 -4) 📝 `client/src/serialize/txt/rdata_parsers/name.rs` (+4 -5) 📝 `client/src/serialize/txt/rdata_parsers/null.rs` (+1 -1) _...and 80 more files_ </details> ### 📄 Description This PR add a rustfmt job that fails when the code is not formatted with rustfmt. Fix https://github.com/bluejekyll/trust-dns/issues/293 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>