[PR #2238] [MERGED] Add conformance tests for NSEC3 #2898

New issue

Closed

opened 2026-03-16 11:14:09 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:14:09 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2238
Author: @pvdrz
Created: 6/13/2024
Status: ✅ Merged
Merged: 6/17/2024
Merged by: @bluejekyll

Base: main ← Head: pvdrz-nsec3-conformance

📝 Commits (6)

0796d01 Add conformance tests for NSEC3
eb481b4 Remove bob
a8131d8 Factor NSEC3 records logic to its own module
053f557 Rename fqdns
28ecafd Remove unnecessary derives
409164c Merge branch 'main' into pvdrz-nsec3-conformance

📊 Changes

7 files changed (+420 additions, -9 deletions)

View changed files

📝 conformance/packages/conformance-tests/src/name_server.rs (+1 -0)
➕ conformance/packages/conformance-tests/src/name_server/rfc5155.rs (+329 -0)
📝 conformance/packages/dns-test/src/fqdn.rs (+5 -0)
📝 conformance/packages/dns-test/src/lib.rs (+1 -0)
➕ conformance/packages/dns-test/src/nsec3.rs (+66 -0)
📝 conformance/packages/dns-test/src/record.rs (+17 -9)
📝 conformance/packages/dns-test/src/zone_file/mod.rs (+1 -0)

📄 Description

This PR adds a conformance test based on sections 7.2.2. to 7.2.6. of RFC 5155

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2238 **Author:** [@pvdrz](https://github.com/pvdrz) **Created:** 6/13/2024 **Status:** ✅ Merged **Merged:** 6/17/2024 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `main` ← **Head:** `pvdrz-nsec3-conformance` --- ### 📝 Commits (6) - [`0796d01`](https://github.com/hickory-dns/hickory-dns/commit/0796d013451315cb32a9f92d9a52b8c66f05a3e8) Add conformance tests for NSEC3 - [`eb481b4`](https://github.com/hickory-dns/hickory-dns/commit/eb481b46d26edb0dce74bbdf3ac957d0c5fad48a) Remove `bob` - [`a8131d8`](https://github.com/hickory-dns/hickory-dns/commit/a8131d8d7dadbcb0516d5befc1fac61413dbef71) Factor NSEC3 records logic to its own module - [`053f557`](https://github.com/hickory-dns/hickory-dns/commit/053f55708ff4d4f24a4dc184ee78f91ea4d33f03) Rename fqdns - [`28ecafd`](https://github.com/hickory-dns/hickory-dns/commit/28ecafd16872af6e8106c7e4260a33d006be4aa8) Remove unnecessary derives - [`409164c`](https://github.com/hickory-dns/hickory-dns/commit/409164c76ceba4b6ef86aab0b2e060e4291ca2d7) Merge branch 'main' into pvdrz-nsec3-conformance ### 📊 Changes **7 files changed** (+420 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `conformance/packages/conformance-tests/src/name_server.rs` (+1 -0) ➕ `conformance/packages/conformance-tests/src/name_server/rfc5155.rs` (+329 -0) 📝 `conformance/packages/dns-test/src/fqdn.rs` (+5 -0) 📝 `conformance/packages/dns-test/src/lib.rs` (+1 -0) ➕ `conformance/packages/dns-test/src/nsec3.rs` (+66 -0) 📝 `conformance/packages/dns-test/src/record.rs` (+17 -9) 📝 `conformance/packages/dns-test/src/zone_file/mod.rs` (+1 -0) </details> ### 📄 Description This PR adds a conformance test based on sections 7.2.2. to 7.2.6. of RFC 5155 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>