[PR #2775] [MERGED] Preserve DNSKEY flags when decoding #3309

New issue

Closed

opened 2026-03-16 11:36:35 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:36:35 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2775
Author: @divergentdave
Created: 2/13/2025
Status: ✅ Merged
Merged: 2/13/2025
Merged by: @divergentdave

Base: main ← Head: david/preserve-dnskey-flags-2

📝 Commits (1)

a3517cf Preserve DNSKEY flags when decoding

📊 Changes

1 file changed (+21 additions, -9 deletions)

View changed files

📝 crates/proto/src/dnssec/rdata/dnskey.rs (+21 -9)

📄 Description

This is a follow-up to #2765 to actually preserve the flags field during decoding. I added a round-trip test as well.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2775 **Author:** [@divergentdave](https://github.com/divergentdave) **Created:** 2/13/2025 **Status:** ✅ Merged **Merged:** 2/13/2025 **Merged by:** [@divergentdave](https://github.com/divergentdave) **Base:** `main` ← **Head:** `david/preserve-dnskey-flags-2` --- ### 📝 Commits (1) - [`a3517cf`](https://github.com/hickory-dns/hickory-dns/commit/a3517cfbcc9e635450701f618832f73d9a1a0256) Preserve DNSKEY flags when decoding ### 📊 Changes **1 file changed** (+21 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `crates/proto/src/dnssec/rdata/dnskey.rs` (+21 -9) </details> ### 📄 Description This is a follow-up to #2765 to actually preserve the flags field during decoding. I added a round-trip test as well. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>