[PR #2040] [MERGED] Privatize the Lexer API #2775

New issue

Closed

opened 2026-03-16 11:07:38 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:07:38 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2040
Author: @djc
Created: 9/25/2023
Status: ✅ Merged
Merged: 9/29/2023
Merged by: @bluejekyll

Base: main ← Head: lex-private

📝 Commits (4)

dd9a805 proto: make sure a Parser is used only once
b360e20 proto: store state in Parser
d5704f1 proto: handle includes in the parser
221099a proto: make the lexer an implementation detail of the parser

📊 Changes

7 files changed (+254 additions, -292 deletions)

View changed files

📝 crates/proto/src/serialize/txt/mod.rs (+1 -1)
📝 crates/proto/src/serialize/txt/rdata_parsers/svcb.rs (+3 -6)
📝 crates/proto/src/serialize/txt/zone.rs (+195 -128)
📝 crates/proto/src/serialize/txt/zone_lex.rs (+32 -9)
📝 crates/server/src/store/file/authority.rs (+5 -118)
📝 crates/server/src/store/recursor/config.rs (+3 -5)
📝 crates/server/tests/txt_tests.rs (+15 -25)

📄 Description

Becomes an implementation detail of the Parser.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2040 **Author:** [@djc](https://github.com/djc) **Created:** 9/25/2023 **Status:** ✅ Merged **Merged:** 9/29/2023 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `main` ← **Head:** `lex-private` --- ### 📝 Commits (4) - [`dd9a805`](https://github.com/hickory-dns/hickory-dns/commit/dd9a80509519da381aac9377ca4f9a4e1d035dae) proto: make sure a Parser is used only once - [`b360e20`](https://github.com/hickory-dns/hickory-dns/commit/b360e20d43b0123e357ec8ffc589af65737755ea) proto: store state in Parser - [`d5704f1`](https://github.com/hickory-dns/hickory-dns/commit/d5704f159b7747f1ff676f43e2dbf0d183977a10) proto: handle includes in the parser - [`221099a`](https://github.com/hickory-dns/hickory-dns/commit/221099a26f31a91c46380fb08d62c7197c33d6b6) proto: make the lexer an implementation detail of the parser ### 📊 Changes **7 files changed** (+254 additions, -292 deletions) <details> <summary>View changed files</summary> 📝 `crates/proto/src/serialize/txt/mod.rs` (+1 -1) 📝 `crates/proto/src/serialize/txt/rdata_parsers/svcb.rs` (+3 -6) 📝 `crates/proto/src/serialize/txt/zone.rs` (+195 -128) 📝 `crates/proto/src/serialize/txt/zone_lex.rs` (+32 -9) 📝 `crates/server/src/store/file/authority.rs` (+5 -118) 📝 `crates/server/src/store/recursor/config.rs` (+3 -5) 📝 `crates/server/tests/txt_tests.rs` (+15 -25) </details> ### 📄 Description Becomes an implementation detail of the `Parser`. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>