[PR #2029] [MERGED] Remove `Copy` from `ResolverOpts` #2765

New issue

Closed

opened 2026-03-16 11:07:06 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:07:06 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2029
Author: @daxpedda
Created: 9/19/2023
Status: ✅ Merged
Merged: 9/19/2023
Merged by: @bluejekyll

Base: main ← Head: resolver-opts-remove-copy

📝 Commits (2)

eb2f6f4 Remove Copy from ResolverOpts
058ae7f Address review

📊 Changes

6 files changed (+35 additions, -34 deletions)

View changed files

📝 crates/recursor/src/recursor.rs (+2 -2)
📝 crates/resolver/src/async_resolver.rs (+3 -2)
📝 crates/resolver/src/config.rs (+2 -2)
📝 crates/resolver/src/name_server/name_server_pool.rs (+20 -20)
📝 crates/server/src/store/forwarder/authority.rs (+1 -1)
📝 tests/integration-tests/tests/name_server_pool_tests.rs (+7 -7)

📄 Description

As discussed in https://github.com/bluejekyll/trust-dns/pull/2001#issuecomment-1725255970.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2029 **Author:** [@daxpedda](https://github.com/daxpedda) **Created:** 9/19/2023 **Status:** ✅ Merged **Merged:** 9/19/2023 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `main` ← **Head:** `resolver-opts-remove-copy` --- ### 📝 Commits (2) - [`eb2f6f4`](https://github.com/hickory-dns/hickory-dns/commit/eb2f6f4d3c3f460f348f682b2795118702694dd3) Remove `Copy` from `ResolverOpts` - [`058ae7f`](https://github.com/hickory-dns/hickory-dns/commit/058ae7f4bc3e26b49844972ee71635d3bd85abb8) Address review ### 📊 Changes **6 files changed** (+35 additions, -34 deletions) <details> <summary>View changed files</summary> 📝 `crates/recursor/src/recursor.rs` (+2 -2) 📝 `crates/resolver/src/async_resolver.rs` (+3 -2) 📝 `crates/resolver/src/config.rs` (+2 -2) 📝 `crates/resolver/src/name_server/name_server_pool.rs` (+20 -20) 📝 `crates/server/src/store/forwarder/authority.rs` (+1 -1) 📝 `tests/integration-tests/tests/name_server_pool_tests.rs` (+7 -7) </details> ### 📄 Description As discussed in https://github.com/bluejekyll/trust-dns/pull/2001#issuecomment-1725255970. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>