[PR #2752] [MERGED] Fix tests on 0.24 release branch #3286

New issue

Closed

opened 2026-03-16 11:35:30 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:35:30 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2752
Author: @divergentdave
Created: 2/7/2025
Status: ✅ Merged
Merged: 2/7/2025
Merged by: @divergentdave

Base: release/0.24 ← Head: david/fix-tests-0.24

📝 Commits (9)

ab0059d Fix clippy lints
51dee96 Update openssl
105f449 Fix example.com tests
7c47601 Skip requests with DAU option in tests
b5e136c Regenerate test private key with correct curve
a14a2bd Stop filtering RRSIGs by DAU option
70cd94a Fix IPv6 example.com tests
f42e68c Fix another example.com test
ffc859f Gate crypto self-test behind OpenSSL feature

📊 Changes

28 files changed (+186 additions, -502 deletions)

View changed files

📝 Cargo.lock (+4 -4)
📝 bin/tests/named_test_rsa_dnssec.rs (+16 -4)
📝 bin/tests/named_tests.rs (+8 -9)
📝 crates/async-std-resolver/src/lib.rs (+1 -6)
📝 crates/client/src/lib.rs (+1 -5)
📝 crates/proto/src/h2/h2_client_stream.rs (+50 -50)
📝 crates/proto/src/h3/h3_client_stream.rs (+50 -50)
📝 crates/proto/src/rr/domain/name.rs (+1 -1)
📝 crates/proto/src/rr/rr_set.rs (+6 -54)
📝 crates/proto/src/xfer/dns_response.rs (+1 -1)
📝 crates/proto/src/xfer/dnssec_dns_handle.rs (+2 -2)
📝 crates/resolver/examples/custom_provider.rs (+2 -14)
📝 crates/resolver/src/async_resolver.rs (+9 -81)
📝 crates/resolver/src/h2.rs (+2 -28)
📝 crates/resolver/src/h3.rs (+2 -28)
📝 crates/resolver/src/lib.rs (+2 -12)
📝 crates/resolver/src/name_server/name_server_pool.rs (+3 -16)
📝 crates/resolver/src/quic.rs (+3 -27)
📝 crates/resolver/src/resolver.rs (+2 -28)
📝 crates/resolver/src/tls/mod.rs (+1 -15)

...and 8 more files

📄 Description

This attempts to fix CI on the release/0.24 branch.

Addressed new Clippy lints
Updated openssl to address advisory
Fixed broken tests that expected particular values from www.example.com (see #2728)
Regenerated a private key that was using the wrong curve (see #2621)
Removed filtering of RRSIGs based on algorithms in DAU options. This is incorrect behavior according to RFC 6975, and it now causes problems because the relevant iterator only returns at most one RRSIG. If multiple keys use the same algorithm, or if multiple algorithms are set in the DAU option, the wrong signature could be chosen. Each test uses a different key in its trust anchor, so all but one were failing when using SupportedAlgorithms::all().

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2752 **Author:** [@divergentdave](https://github.com/divergentdave) **Created:** 2/7/2025 **Status:** ✅ Merged **Merged:** 2/7/2025 **Merged by:** [@divergentdave](https://github.com/divergentdave) **Base:** `release/0.24` ← **Head:** `david/fix-tests-0.24` --- ### 📝 Commits (9) - [`ab0059d`](https://github.com/hickory-dns/hickory-dns/commit/ab0059d780f79e3cec7f5ea815be7bef8236d2e6) Fix clippy lints - [`51dee96`](https://github.com/hickory-dns/hickory-dns/commit/51dee968fb00d2e1d4c2f70e98e09f07d1da403e) Update openssl - [`105f449`](https://github.com/hickory-dns/hickory-dns/commit/105f449ca7ad9a0de2bd81ae0f5a6d6db0d97bc1) Fix example.com tests - [`7c47601`](https://github.com/hickory-dns/hickory-dns/commit/7c476012cb3a58b85f36c4d893e44a40e6f93766) Skip requests with DAU option in tests - [`b5e136c`](https://github.com/hickory-dns/hickory-dns/commit/b5e136c5a5d1bd9d59a9ad138aec1af94ab5deb9) Regenerate test private key with correct curve - [`a14a2bd`](https://github.com/hickory-dns/hickory-dns/commit/a14a2bd322bca53135c6e872cb59ed0e00965271) Stop filtering RRSIGs by DAU option - [`70cd94a`](https://github.com/hickory-dns/hickory-dns/commit/70cd94ac63d96857b11fb2bf582a092ccbbf911f) Fix IPv6 example.com tests - [`f42e68c`](https://github.com/hickory-dns/hickory-dns/commit/f42e68c8d65e4fd0838915a5f419c44e26506ac6) Fix another example.com test - [`ffc859f`](https://github.com/hickory-dns/hickory-dns/commit/ffc859fc51e972a262a0fd147fd3fdfc95c32aa0) Gate crypto self-test behind OpenSSL feature ### 📊 Changes **28 files changed** (+186 additions, -502 deletions) <details> <summary>View changed files</summary> 📝 `Cargo.lock` (+4 -4) 📝 `bin/tests/named_test_rsa_dnssec.rs` (+16 -4) 📝 `bin/tests/named_tests.rs` (+8 -9) 📝 `crates/async-std-resolver/src/lib.rs` (+1 -6) 📝 `crates/client/src/lib.rs` (+1 -5) 📝 `crates/proto/src/h2/h2_client_stream.rs` (+50 -50) 📝 `crates/proto/src/h3/h3_client_stream.rs` (+50 -50) 📝 `crates/proto/src/rr/domain/name.rs` (+1 -1) 📝 `crates/proto/src/rr/rr_set.rs` (+6 -54) 📝 `crates/proto/src/xfer/dns_response.rs` (+1 -1) 📝 `crates/proto/src/xfer/dnssec_dns_handle.rs` (+2 -2) 📝 `crates/resolver/examples/custom_provider.rs` (+2 -14) 📝 `crates/resolver/src/async_resolver.rs` (+9 -81) 📝 `crates/resolver/src/h2.rs` (+2 -28) 📝 `crates/resolver/src/h3.rs` (+2 -28) 📝 `crates/resolver/src/lib.rs` (+2 -12) 📝 `crates/resolver/src/name_server/name_server_pool.rs` (+3 -16) 📝 `crates/resolver/src/quic.rs` (+3 -27) 📝 `crates/resolver/src/resolver.rs` (+2 -28) 📝 `crates/resolver/src/tls/mod.rs` (+1 -15) _...and 8 more files_ </details> ### 📄 Description This attempts to fix CI on the release/0.24 branch. * Addressed new Clippy lints * Updated openssl to address advisory * Fixed broken tests that expected particular values from `www.example.com` (see #2728) * Regenerated a private key that was using the wrong curve (see #2621) * Removed filtering of RRSIGs based on algorithms in DAU options. This is incorrect behavior according to RFC 6975, and it now causes problems because the relevant iterator only returns at most one RRSIG. If multiple keys use the same algorithm, or if multiple algorithms are set in the DAU option, the wrong signature could be chosen. Each test uses a different key in its trust anchor, so all but one were failing when using `SupportedAlgorithms::all()`. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>