[PR #1811] [MERGED] Create dedicated Errors types for Tsig error case. #2621

Closed
opened 2026-03-16 10:48:02 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/1811
Author: @darnuria
Created: 10/28/2022
Status: Merged
Merged: 12/4/2022
Merged by: @bluejekyll

Base: mainHead: tsig/errors


📝 Commits (1)

  • 557eb4f Tsig: Create Error type for unsupported Mac algorithm and Wrong key.

📊 Changes

3 files changed (+24 additions, -7 deletions)

View changed files

📝 crates/client/src/rr/dnssec/tsig.rs (+3 -2)
📝 crates/proto/src/error.rs (+16 -0)
📝 crates/proto/src/rr/dnssec/rdata/tsig.rs (+5 -5)

📄 Description

Don't know if it's really pertinant, may be if in the future futher TSIG support is added.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/1811 **Author:** [@darnuria](https://github.com/darnuria) **Created:** 10/28/2022 **Status:** ✅ Merged **Merged:** 12/4/2022 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `main` ← **Head:** `tsig/errors` --- ### 📝 Commits (1) - [`557eb4f`](https://github.com/hickory-dns/hickory-dns/commit/557eb4f876542d0316ac9e5867012fe2d4efa095) Tsig: Create Error type for unsupported Mac algorithm and Wrong key. ### 📊 Changes **3 files changed** (+24 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `crates/client/src/rr/dnssec/tsig.rs` (+3 -2) 📝 `crates/proto/src/error.rs` (+16 -0) 📝 `crates/proto/src/rr/dnssec/rdata/tsig.rs` (+5 -5) </details> ### 📄 Description Don't know if it's really pertinant, may be if in the future futher TSIG support is added. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-16 10:48:02 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/hickory-dns#2621
No description provided.