[PR #2003] [CLOSED] Add `QuicClientStreamBuilder::endpoint()` #2752

New issue

Closed

opened 2026-03-16 11:06:17 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:06:17 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2003
Author: @daxpedda
Created: 8/21/2023
Status: ❌ Closed

Base: main ← Head: endpoint

📝 Commits (1)

2eb4813 Add QuicClientStreamBuilder::endpoint()

📊 Changes

1 file changed (+87 additions, -34 deletions)

View changed files

📝 crates/proto/src/quic/quic_client_stream.rs (+87 -34)

📄 Description

This adds the option to supply a quinn::Endpoint directly to QuicClientStreamBuilder.

Figure out what to do with 0-RTT. See https://github.com/bluejekyll/trust-dns/issues/2002#issuecomment-1687069256.
Resolved by https://github.com/bluejekyll/trust-dns/issues/2002#issuecomment-1687714407.
Figure out what to do in trust-dns-resolver. Currently stuck on NameServerConfig requiring Eq, which Endpoint doesn't implement, we could always return "not equal" if the endpoint wasn't populated. Alternatively I was thinking that it might be better to store Endpoint in GenericConnector.

Fixes #2002.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2003 **Author:** [@daxpedda](https://github.com/daxpedda) **Created:** 8/21/2023 **Status:** ❌ Closed **Base:** `main` ← **Head:** `endpoint` --- ### 📝 Commits (1) - [`2eb4813`](https://github.com/hickory-dns/hickory-dns/commit/2eb4813095aadf2dcc75b05108d808199d35a012) Add `QuicClientStreamBuilder::endpoint()` ### 📊 Changes **1 file changed** (+87 additions, -34 deletions) <details> <summary>View changed files</summary> 📝 `crates/proto/src/quic/quic_client_stream.rs` (+87 -34) </details> ### 📄 Description This adds the option to supply a `quinn::Endpoint` directly to `QuicClientStreamBuilder`. - [x] Figure out what to do with 0-RTT. See https://github.com/bluejekyll/trust-dns/issues/2002#issuecomment-1687069256. Resolved by https://github.com/bluejekyll/trust-dns/issues/2002#issuecomment-1687714407. - [ ] Figure out what to do in `trust-dns-resolver`. Currently stuck on `NameServerConfig` requiring `Eq`, which `Endpoint` doesn't implement, we could always return "not equal" if the endpoint wasn't populated. Alternatively I was thinking that it might be better to store `Endpoint` in `GenericConnector`. Fixes #2002. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>