[PR #2709] [MERGED] proto: remove server TLS utils #3257

New issue

Closed

opened 2026-03-16 11:33:52 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:33:52 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2709
Author: @djc
Created: 1/6/2025
Status: ✅ Merged
Merged: 1/7/2025
Merged by: @djc

Base: main ← Head: server-tls

📝 Commits (6)

a08deea server: move TLS server config helper
9099fb9 server: require caller to specify ALPN protocol
1119e86 server: handle error conversion in helper
4aa89ef server: inline trivial single-caller function read_key_from_der()
8d871e8 Inline trivial function read_key()
bde43a1 Inline trivial function read_cert()

📊 Changes

6 files changed (+109 additions, -180 deletions)

View changed files

📝 bin/src/lib.rs (+24 -6)
📝 crates/proto/src/quic/tests.rs (+17 -15)
📝 crates/proto/src/rustls/mod.rs (+0 -1)
➖ crates/proto/src/rustls/tls_server.rs (+0 -91)
📝 crates/server/src/server/server_future.rs (+46 -44)
📝 tests/integration-tests/tests/integration/server_future_tests.rs (+22 -23)

📄 Description

This is a pretty thin API on top of rustls-pki-types and documenting/generalizing it for public use seems overkill.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2709 **Author:** [@djc](https://github.com/djc) **Created:** 1/6/2025 **Status:** ✅ Merged **Merged:** 1/7/2025 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `server-tls` --- ### 📝 Commits (6) - [`a08deea`](https://github.com/hickory-dns/hickory-dns/commit/a08deeacde8f7edb683e948e9d83d3894998ff5b) server: move TLS server config helper - [`9099fb9`](https://github.com/hickory-dns/hickory-dns/commit/9099fb9a8a9b07104c87a20abc4f076773f5e283) server: require caller to specify ALPN protocol - [`1119e86`](https://github.com/hickory-dns/hickory-dns/commit/1119e8602f72a2613fa31607fef423a0b8848f80) server: handle error conversion in helper - [`4aa89ef`](https://github.com/hickory-dns/hickory-dns/commit/4aa89ef1fb93e248f9dc2d4e97aa1cd987ff4c9d) server: inline trivial single-caller function read_key_from_der() - [`8d871e8`](https://github.com/hickory-dns/hickory-dns/commit/8d871e8ffbe2c5800f86066285835ba97ea743c8) Inline trivial function read_key() - [`bde43a1`](https://github.com/hickory-dns/hickory-dns/commit/bde43a1e776b1c5fced79744aef6c3a6f29dd19f) Inline trivial function read_cert() ### 📊 Changes **6 files changed** (+109 additions, -180 deletions) <details> <summary>View changed files</summary> 📝 `bin/src/lib.rs` (+24 -6) 📝 `crates/proto/src/quic/tests.rs` (+17 -15) 📝 `crates/proto/src/rustls/mod.rs` (+0 -1) ➖ `crates/proto/src/rustls/tls_server.rs` (+0 -91) 📝 `crates/server/src/server/server_future.rs` (+46 -44) 📝 `tests/integration-tests/tests/integration/server_future_tests.rs` (+22 -23) </details> ### 📄 Description This is a pretty thin API on top of rustls-pki-types and documenting/generalizing it for public use seems overkill. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>