[PR #1942] [MERGED] Return `Self` from `AsyncResolver::new()` #2709

New issue

Closed

opened 2026-03-16 11:03:50 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:03:50 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/1942
Author: @daxpedda
Created: 5/21/2023
Status: ✅ Merged
Merged: 5/22/2023
Merged by: @djc

Base: main ← Head: resolver-error

📝 Commits (1)

ab0d31c Return Self from AsyncResolver::new()

📊 Changes

10 files changed (+35 additions, -67 deletions)

View changed files

📝 crates/async-std-resolver/README.md (+1 -1)
📝 crates/async-std-resolver/src/lib.rs (+2 -2)
📝 crates/resolver/examples/custom_provider.rs (+2 -4)
📝 crates/resolver/src/async_resolver.rs (+23 -49)
📝 crates/resolver/src/https.rs (+1 -2)
📝 crates/resolver/src/lib.rs (+2 -2)
📝 crates/resolver/src/resolver.rs (+1 -2)
📝 crates/resolver/src/tls/mod.rs (+1 -2)
📝 crates/server/src/store/forwarder/authority.rs (+1 -2)
📝 util/src/resolve.rs (+1 -1)

📄 Description

I was wondering how this can return an error and found out that it just can't. Maybe it was left this way to avoid breaking changes?

Is this desirable?

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/1942 **Author:** [@daxpedda](https://github.com/daxpedda) **Created:** 5/21/2023 **Status:** ✅ Merged **Merged:** 5/22/2023 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `resolver-error` --- ### 📝 Commits (1) - [`ab0d31c`](https://github.com/hickory-dns/hickory-dns/commit/ab0d31c32032753bae69586e96309c20f4b12a95) Return `Self` from `AsyncResolver::new()` ### 📊 Changes **10 files changed** (+35 additions, -67 deletions) <details> <summary>View changed files</summary> 📝 `crates/async-std-resolver/README.md` (+1 -1) 📝 `crates/async-std-resolver/src/lib.rs` (+2 -2) 📝 `crates/resolver/examples/custom_provider.rs` (+2 -4) 📝 `crates/resolver/src/async_resolver.rs` (+23 -49) 📝 `crates/resolver/src/https.rs` (+1 -2) 📝 `crates/resolver/src/lib.rs` (+2 -2) 📝 `crates/resolver/src/resolver.rs` (+1 -2) 📝 `crates/resolver/src/tls/mod.rs` (+1 -2) 📝 `crates/server/src/store/forwarder/authority.rs` (+1 -2) 📝 `util/src/resolve.rs` (+1 -1) </details> ### 📄 Description I was wondering how this can return an error and found out that it just can't. Maybe it was left this way to avoid breaking changes? Is this desirable? --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>