[PR #3257] [MERGED] justfile: improve clippy target #3685

New issue

Closed

opened 2026-03-16 11:57:14 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:57:14 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/3257
Author: @djc
Created: 9/4/2025
Status: ✅ Merged
Merged: 9/4/2025
Merged by: @djc

Base: main ← Head: ci-clippy

📝 Commits (2)

4f372e0 justfile: run clippy with --all-features first
26842a8 justfile: keep going across crates even if clippy fails

📊 Changes

1 file changed (+2 additions, -2 deletions)

View changed files

📝 justfile (+2 -2)

📄 Description

The way justfile clippy is used in the CI cleanliness job led to progress disclosure, where partial lint denials would lead to the job ending while after pushing a fix another issue would be found. It seems that cargo ws exec stops after the first failure, which is suboptimal for this use case.

Also, the --all-features variant is most likely to find issues, so run it first.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/3257 **Author:** [@djc](https://github.com/djc) **Created:** 9/4/2025 **Status:** ✅ Merged **Merged:** 9/4/2025 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `ci-clippy` --- ### 📝 Commits (2) - [`4f372e0`](https://github.com/hickory-dns/hickory-dns/commit/4f372e0b50abc1a176a17be211ad0b22ccc66f22) justfile: run clippy with --all-features first - [`26842a8`](https://github.com/hickory-dns/hickory-dns/commit/26842a8154b19453046f6952216070fbbfc4ef74) justfile: keep going across crates even if clippy fails ### 📊 Changes **1 file changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `justfile` (+2 -2) </details> ### 📄 Description The way `justfile clippy` is used in the CI cleanliness job led to progress disclosure, where partial lint denials would lead to the job ending while after pushing a fix another issue would be found. It seems that `cargo ws exec` stops after the first failure, which is suboptimal for this use case. Also, the `--all-features` variant is most likely to find issues, so run it first. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>