[PR #2610] [MERGED] Box the query in ProtoErrorKind::Nsec #3175

New issue

Closed

opened 2026-03-16 11:29:32 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:29:32 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2610
Author: @divergentdave
Created: 11/22/2024
Status: ✅ Merged
Merged: 11/23/2024
Merged by: @djc

Base: main ← Head: david/box-proto-error-nsec-query

📝 Commits (1)

0385243 Box the query in ProtoErrorKind::Nsec

📊 Changes

2 files changed (+2 additions, -2 deletions)

View changed files

📝 crates/proto/src/error.rs (+1 -1)
📝 crates/proto/src/xfer/dnssec_dns_handle/mod.rs (+1 -1)

📄 Description

This boxes the query field in the NSEC error variant. This brings it in line with ProtoErrorKind::NoRecordsFound and ForwardData, plus it reduces the size of the enum from 104 bytes to 88 bytes on an all-features x86_64-unknown-linux-gnu build.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2610 **Author:** [@divergentdave](https://github.com/divergentdave) **Created:** 11/22/2024 **Status:** ✅ Merged **Merged:** 11/23/2024 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `david/box-proto-error-nsec-query` --- ### 📝 Commits (1) - [`0385243`](https://github.com/hickory-dns/hickory-dns/commit/03852438abb6caabc172ad86117339f8fbf38e00) Box the query in ProtoErrorKind::Nsec ### 📊 Changes **2 files changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `crates/proto/src/error.rs` (+1 -1) 📝 `crates/proto/src/xfer/dnssec_dns_handle/mod.rs` (+1 -1) </details> ### 📄 Description This boxes the query field in the NSEC error variant. This brings it in line with `ProtoErrorKind::NoRecordsFound` and `ForwardData`, plus it reduces the size of the enum from 104 bytes to 88 bytes on an all-features x86_64-unknown-linux-gnu build. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>