[PR #1796] [MERGED] proto: only allow ASCII characters in CAA key/value data #2610

New issue

Closed

opened 2026-03-16 10:47:25 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 10:47:25 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/1796
Author: @djc
Created: 10/13/2022
Status: ✅ Merged
Merged: 10/17/2022
Merged by: @bluejekyll

Base: main ← Head: caa-read-unicode

📝 Commits (1)

bfaf255 proto: only allow ASCII characters in CAA key/value data

📊 Changes

1 file changed (+18 additions, -2 deletions)

View changed files

📝 crates/proto/src/rr/rdata/caa.rs (+18 -2)

📄 Description

This should take care of the issue found in by OSS-Fuzz in https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=52327. I think the cause here is just a mismatch between the ALPHA / DIGIT syntax specified in the spec and the Rust naming of char methods, which are Unicode-aware by default and thus accept a much wider range of characters.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/1796 **Author:** [@djc](https://github.com/djc) **Created:** 10/13/2022 **Status:** ✅ Merged **Merged:** 10/17/2022 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `main` ← **Head:** `caa-read-unicode` --- ### 📝 Commits (1) - [`bfaf255`](https://github.com/hickory-dns/hickory-dns/commit/bfaf255880b4f865fa89c3ad46310db91037e129) proto: only allow ASCII characters in CAA key/value data ### 📊 Changes **1 file changed** (+18 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `crates/proto/src/rr/rdata/caa.rs` (+18 -2) </details> ### 📄 Description This should take care of the issue found in by OSS-Fuzz in https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=52327. I think the cause here is just a mismatch between the `ALPHA / DIGIT` syntax specified in the spec and the Rust naming of `char` methods, which are Unicode-aware by default and thus accept a much wider range of characters. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>