[PR #3208] [MERGED] NSEC verification tweaks #3642

New issue

Closed

opened 2026-03-16 11:54:47 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:54:47 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/3208
Author: @djc
Created: 8/16/2025
Status: ✅ Merged
Merged: 8/16/2025
Merged by: @djc

Base: main ← Head: nsec-tweaks

📝 Commits (10+)

7d0698b proto: move Nsec3RecordPair down
5e3e69c proto: move wildcard_based_encloser_proof() to ClosestEncloserProofInfo::from_wildcard()
2a14bdc proto: derive Default for ClosestEncloserProofInfo
2413915 proto: move HashedNameInfo down
c160bf3 proto: move ClosestEncloserProofInfo down
6d72ef1 proto: move find_covering_record() down
1e15249 proto: move validate_nodata_response() up
ef974a2 proto: move validate_nxdomain_response() up
15dda69 proto: move nsec1_yield() before proof_log_yield()
bae1b6e proto: drop pointless field privacy

📊 Changes

8 files changed (+893 additions, -939 deletions)

View changed files

➖ crates/proto/src/dnssec/dnssec_dns_handle/nsec3_validation.rs (+0 -833)
📝 crates/proto/src/dnssec/handle.rs (+63 -78)
📝 crates/proto/src/dnssec/mod.rs (+30 -16)
📝 crates/proto/src/dnssec/nsec3.rs (+795 -6)
📝 crates/proto/src/dnssec/tbs.rs (+1 -1)
📝 crates/server/src/store/sqlite/mod.rs (+1 -2)
📝 tests/compatibility-tests/tests/integration/tsig_tests.rs (+1 -1)
📝 tests/integration-tests/tests/integration/sqlite_authority_tests.rs (+2 -2)

📄 Description

Followup from

#3175

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/3208 **Author:** [@djc](https://github.com/djc) **Created:** 8/16/2025 **Status:** ✅ Merged **Merged:** 8/16/2025 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `nsec-tweaks` --- ### 📝 Commits (10+) - [`7d0698b`](https://github.com/hickory-dns/hickory-dns/commit/7d0698b5ec09ce7b139e32e7dc5a021b1639ac5b) proto: move Nsec3RecordPair down - [`5e3e69c`](https://github.com/hickory-dns/hickory-dns/commit/5e3e69cb01620db4bc97cd97c6731173322ba7a0) proto: move wildcard_based_encloser_proof() to ClosestEncloserProofInfo::from_wildcard() - [`2a14bdc`](https://github.com/hickory-dns/hickory-dns/commit/2a14bdccb2adf1d881f0029cfe89af15c62361b1) proto: derive Default for ClosestEncloserProofInfo - [`2413915`](https://github.com/hickory-dns/hickory-dns/commit/24139155853bfa776a3b19c1262bde87c4d66056) proto: move HashedNameInfo down - [`c160bf3`](https://github.com/hickory-dns/hickory-dns/commit/c160bf3c3ef0bb9dfd71cc80987b236d515f8f0c) proto: move ClosestEncloserProofInfo down - [`6d72ef1`](https://github.com/hickory-dns/hickory-dns/commit/6d72ef14eda9bc0d360c10190b4fcc38561d22e2) proto: move find_covering_record() down - [`1e15249`](https://github.com/hickory-dns/hickory-dns/commit/1e15249fe569a29d444029e042951cf1985e9de6) proto: move validate_nodata_response() up - [`ef974a2`](https://github.com/hickory-dns/hickory-dns/commit/ef974a2961abee2ab136e87b608fdacbbd73549c) proto: move validate_nxdomain_response() up - [`15dda69`](https://github.com/hickory-dns/hickory-dns/commit/15dda699514441ad0d4e459306f5f59bf85085d2) proto: move nsec1_yield() before proof_log_yield() - [`bae1b6e`](https://github.com/hickory-dns/hickory-dns/commit/bae1b6e022fbebbf2a89f97e47357dd6c57b8ed8) proto: drop pointless field privacy ### 📊 Changes **8 files changed** (+893 additions, -939 deletions) <details> <summary>View changed files</summary> ➖ `crates/proto/src/dnssec/dnssec_dns_handle/nsec3_validation.rs` (+0 -833) 📝 `crates/proto/src/dnssec/handle.rs` (+63 -78) 📝 `crates/proto/src/dnssec/mod.rs` (+30 -16) 📝 `crates/proto/src/dnssec/nsec3.rs` (+795 -6) 📝 `crates/proto/src/dnssec/tbs.rs` (+1 -1) 📝 `crates/server/src/store/sqlite/mod.rs` (+1 -2) 📝 `tests/compatibility-tests/tests/integration/tsig_tests.rs` (+1 -1) 📝 `tests/integration-tests/tests/integration/sqlite_authority_tests.rs` (+2 -2) </details> ### 📄 Description Followup from - #3175 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>