[PR #2587] [MERGED] Add cargo-all-features configuration #3162

New issue

Closed

opened 2026-03-16 11:28:43 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:28:43 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2587
Author: @divergentdave
Created: 11/18/2024
Status: ✅ Merged
Merged: 11/21/2024
Merged by: @djc

Base: main ← Head: david/cargo-all-features

📝 Commits (1)

08b558b Add cargo-all-features configuration

📊 Changes

8 files changed (+39 additions, -0 deletions)

View changed files

📝 bin/Cargo.toml (+5 -0)
📝 crates/client/Cargo.toml (+5 -0)
📝 crates/proto/Cargo.toml (+5 -0)
📝 crates/recursor/Cargo.toml (+5 -0)
📝 crates/resolver/Cargo.toml (+5 -0)
📝 crates/server/Cargo.toml (+5 -0)
📝 tests/integration-tests/Cargo.toml (+5 -0)
📝 util/Cargo.toml (+4 -0)

📄 Description

This adds some package.metadata configuration to enable using cargo-all-features. I limited the number of features to enable at a time, because the powerset is impractically large in most cases. I set it to skip the dnssec and dns-over-tls features as appropriate, since these aren't intended to be enabled directly. Between this, #2584, #2585, and #2586, I got cargo check-all-features to pass.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2587 **Author:** [@divergentdave](https://github.com/divergentdave) **Created:** 11/18/2024 **Status:** ✅ Merged **Merged:** 11/21/2024 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `david/cargo-all-features` --- ### 📝 Commits (1) - [`08b558b`](https://github.com/hickory-dns/hickory-dns/commit/08b558beca8ce8de66d9a862f61e654553bf8168) Add cargo-all-features configuration ### 📊 Changes **8 files changed** (+39 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `bin/Cargo.toml` (+5 -0) 📝 `crates/client/Cargo.toml` (+5 -0) 📝 `crates/proto/Cargo.toml` (+5 -0) 📝 `crates/recursor/Cargo.toml` (+5 -0) 📝 `crates/resolver/Cargo.toml` (+5 -0) 📝 `crates/server/Cargo.toml` (+5 -0) 📝 `tests/integration-tests/Cargo.toml` (+5 -0) 📝 `util/Cargo.toml` (+4 -0) </details> ### 📄 Description This adds some `package.metadata` configuration to enable using [`cargo-all-features`](https://github.com/frewsxcv/cargo-all-features). I limited the number of features to enable at a time, because the powerset is impractically large in most cases. I set it to skip the `dnssec` and `dns-over-tls` features as appropriate, since these aren't intended to be enabled directly. Between this, #2584, #2585, and #2586, I got `cargo check-all-features` to pass. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>