[PR #1755] [MERGED] Add invalid utf8 output test for TXT::fmt. #2584

New issue

Closed

opened 2026-03-16 10:43:01 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 10:43:01 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/1755
Author: @darnuria
Created: 8/6/2022
Status: ✅ Merged
Merged: 8/24/2022
Merged by: @bluejekyll

Base: main ← Head: coverage/fmt-display-txt

📝 Commits (2)

57ec874 Add invalid utf8 output test for TXT::fmt.
ae584f9 fixup! Apply @bluejekyll request: Pass test as doctest.

📊 Changes

1 file changed (+22 additions, -0 deletions)

View changed files

📝 crates/proto/src/rr/rdata/txt.rs (+22 -0)

📄 Description

It's a first small one, hope it's not too useless. ;)

Edit:
Maybe just a doc test is enough?

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/1755 **Author:** [@darnuria](https://github.com/darnuria) **Created:** 8/6/2022 **Status:** ✅ Merged **Merged:** 8/24/2022 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `main` ← **Head:** `coverage/fmt-display-txt` --- ### 📝 Commits (2) - [`57ec874`](https://github.com/hickory-dns/hickory-dns/commit/57ec87400af32cd9d21cd3fc71f46c11e5ea4049) Add invalid utf8 output test for TXT::fmt. - [`ae584f9`](https://github.com/hickory-dns/hickory-dns/commit/ae584f9976c0d33016962d9ab25226b52a23eb1c) fixup! Apply @bluejekyll request: Pass test as doctest. ### 📊 Changes **1 file changed** (+22 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `crates/proto/src/rr/rdata/txt.rs` (+22 -0) </details> ### 📄 Description It's a first small one, hope it's not too useless. ;) Edit: Maybe just a doc test is enough? --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>