[PR #1764] [MERGED] Fix clippy #2587

New issue

Closed

opened 2026-03-16 10:43:18 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 10:43:18 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/1764
Author: @darnuria
Created: 8/11/2022
Status: ✅ Merged
Merged: 8/18/2022
Merged by: @bluejekyll

Base: main ← Head: fix-clippy

📝 Commits (7)

a5f4f25 Clippy: unnecessary structure name repetition use Self.
9d04833 Clippy: accessing first element with self.remaining.get(0).
84e9b54 Clippy: this expression borrows a value the compiler would automatically borrow.
09f9e45 Clippy: deref which would be done by auto-deref.
7ad1bb8 Clippy: deref on an immutable reference.
84459f3 Clippy poll_next: use ? manual rewrite.
b3ed247 Clippy derive Eq if PartialEq already derived.

📊 Changes

33 files changed (+99 additions, -109 deletions)

View changed files

📝 crates/client/src/client/async_client.rs (+6 -16)
📝 crates/client/src/client/client_connection.rs (+2 -2)
📝 crates/client/src/op/lower_query.rs (+1 -1)
📝 crates/client/src/rr/dnssec/keypair.rs (+10 -10)
📝 crates/client/src/rr/zone.rs (+19 -19)
📝 crates/proto/src/https/https_client_stream.rs (+6 -6)
📝 crates/proto/src/op/edns.rs (+1 -1)
📝 crates/proto/src/op/message.rs (+2 -2)
📝 crates/proto/src/rr/dnssec/ec_public_key.rs (+1 -1)
📝 crates/proto/src/rr/dnssec/rsa_public_key.rs (+1 -1)
📝 crates/proto/src/rr/domain/try_parse_ip.rs (+1 -1)
📝 crates/proto/src/rr/domain/usage.rs (+8 -8)
📝 crates/proto/src/rr/rdata/opt.rs (+1 -1)
📝 crates/proto/src/rr/rr_set.rs (+2 -2)
📝 crates/proto/src/serialize/binary/decoder.rs (+1 -1)
📝 crates/proto/src/xfer/dns_exchange.rs (+3 -3)
📝 crates/proto/src/xfer/dns_request.rs (+1 -1)
📝 crates/proto/src/xfer/mod.rs (+3 -3)
📝 crates/resolver/src/lookup.rs (+6 -6)
📝 crates/resolver/src/name_server/name_server_pool.rs (+5 -5)

...and 13 more files

📄 Description

Some commits to fix CI breakage of clippy, feel free to pick what's pertinant or roll'up. I didn't make the derive Eq suggestion because didn't know what is the policy about Eq.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/1764 **Author:** [@darnuria](https://github.com/darnuria) **Created:** 8/11/2022 **Status:** ✅ Merged **Merged:** 8/18/2022 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `main` ← **Head:** `fix-clippy` --- ### 📝 Commits (7) - [`a5f4f25`](https://github.com/hickory-dns/hickory-dns/commit/a5f4f256ff64cb025ff97b3c58b9e179eb70d160) Clippy: unnecessary structure name repetition use Self. - [`9d04833`](https://github.com/hickory-dns/hickory-dns/commit/9d048337a9807e57c3619105f61ff114b9803fbd) Clippy: accessing first element with self.remaining.get(0). - [`84e9b54`](https://github.com/hickory-dns/hickory-dns/commit/84e9b545e2259ed773367d9afa3f0c3e7524c1e6) Clippy: this expression borrows a value the compiler would automatically borrow. - [`09f9e45`](https://github.com/hickory-dns/hickory-dns/commit/09f9e45e02c00c6a9a3c94e913ff90548afead49) Clippy: deref which would be done by auto-deref. - [`7ad1bb8`](https://github.com/hickory-dns/hickory-dns/commit/7ad1bb8db701c792bdb63be7de908371fec65585) Clippy: deref on an immutable reference. - [`84459f3`](https://github.com/hickory-dns/hickory-dns/commit/84459f3c288e9db860f46aee077388183f87a14f) Clippy poll_next: use ? manual rewrite. - [`b3ed247`](https://github.com/hickory-dns/hickory-dns/commit/b3ed2475bdf1d1c0b960b4c150743e103547a4c9) Clippy derive Eq if PartialEq already derived. ### 📊 Changes **33 files changed** (+99 additions, -109 deletions) <details> <summary>View changed files</summary> 📝 `crates/client/src/client/async_client.rs` (+6 -16) 📝 `crates/client/src/client/client_connection.rs` (+2 -2) 📝 `crates/client/src/op/lower_query.rs` (+1 -1) 📝 `crates/client/src/rr/dnssec/keypair.rs` (+10 -10) 📝 `crates/client/src/rr/zone.rs` (+19 -19) 📝 `crates/proto/src/https/https_client_stream.rs` (+6 -6) 📝 `crates/proto/src/op/edns.rs` (+1 -1) 📝 `crates/proto/src/op/message.rs` (+2 -2) 📝 `crates/proto/src/rr/dnssec/ec_public_key.rs` (+1 -1) 📝 `crates/proto/src/rr/dnssec/rsa_public_key.rs` (+1 -1) 📝 `crates/proto/src/rr/domain/try_parse_ip.rs` (+1 -1) 📝 `crates/proto/src/rr/domain/usage.rs` (+8 -8) 📝 `crates/proto/src/rr/rdata/opt.rs` (+1 -1) 📝 `crates/proto/src/rr/rr_set.rs` (+2 -2) 📝 `crates/proto/src/serialize/binary/decoder.rs` (+1 -1) 📝 `crates/proto/src/xfer/dns_exchange.rs` (+3 -3) 📝 `crates/proto/src/xfer/dns_request.rs` (+1 -1) 📝 `crates/proto/src/xfer/mod.rs` (+3 -3) 📝 `crates/resolver/src/lookup.rs` (+6 -6) 📝 `crates/resolver/src/name_server/name_server_pool.rs` (+5 -5) _...and 13 more files_ </details> ### 📄 Description Some commits to fix CI breakage of clippy, feel free to pick what's pertinant or roll'up. I didn't make the derive `Eq` suggestion because didn't know what is the policy about `Eq`. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>