[PR #2531] [MERGED] Recursor CNAME resource limit improvements #3112

New issue

Closed

opened 2026-03-16 11:25:51 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:25:51 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2531
Author: @marcus0x62
Created: 10/26/2024
Status: ✅ Merged
Merged: 11/4/2024
Merged by: @marcus0x62

Base: main ← Head: recursor_cname_improvements

📝 Commits (2)

3b3603e Enforce CNAME lookup limits
8c02db5 test for cname loop

📊 Changes

5 files changed (+155 additions, -9 deletions)

View changed files

📝 crates/proto/src/error.rs (+12 -0)
📝 crates/recursor/src/recursor.rs (+17 -4)
📝 crates/recursor/src/recursor_dns_handle.rs (+45 -5)
➕ tests/e2e-tests/src/recursor/cname/cname_loop.py (+28 -0)
📝 tests/e2e-tests/src/recursor/cname/scenarios.rs (+53 -0)

📄 Description

Introduce an overall CNAME record lookup limit in the recursor to guard against memory exhaustion. (Currently based off of the recursor_recursion_improvements branch.)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2531 **Author:** [@marcus0x62](https://github.com/marcus0x62) **Created:** 10/26/2024 **Status:** ✅ Merged **Merged:** 11/4/2024 **Merged by:** [@marcus0x62](https://github.com/marcus0x62) **Base:** `main` ← **Head:** `recursor_cname_improvements` --- ### 📝 Commits (2) - [`3b3603e`](https://github.com/hickory-dns/hickory-dns/commit/3b3603e67a423c6aad5b7a63a48626787f88d319) Enforce CNAME lookup limits - [`8c02db5`](https://github.com/hickory-dns/hickory-dns/commit/8c02db5d28c233627170d0d390da193384a54616) test for cname loop ### 📊 Changes **5 files changed** (+155 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `crates/proto/src/error.rs` (+12 -0) 📝 `crates/recursor/src/recursor.rs` (+17 -4) 📝 `crates/recursor/src/recursor_dns_handle.rs` (+45 -5) ➕ `tests/e2e-tests/src/recursor/cname/cname_loop.py` (+28 -0) 📝 `tests/e2e-tests/src/recursor/cname/scenarios.rs` (+53 -0) </details> ### 📄 Description Introduce an overall CNAME record lookup limit in the recursor to guard against memory exhaustion. (Currently based off of the recursor_recursion_improvements branch.) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>