[PR #3112] [MERGED] resolver: make ResolverConfig fields public #3565

New issue

Closed

opened 2026-03-16 11:50:42 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:50:42 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/3112
Author: @djc
Created: 7/12/2025
Status: ✅ Merged
Merged: 7/12/2025
Merged by: @djc

Base: main ← Head: resolver-config-pub

📝 Commits (1)

fa696d7 resolver: make ResolverConfig fields public

📊 Changes

1 file changed (+7 additions, -6 deletions)

View changed files

📝 crates/resolver/src/config.rs (+7 -6)

📄 Description

But make it non-exhaustive so that we can add new fields in the future.

I think these fields have been pretty stable over time and there are no invariants that need to be maintained across fields, so there's not much justification for keeping it all private.

Fixes #1899.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/3112 **Author:** [@djc](https://github.com/djc) **Created:** 7/12/2025 **Status:** ✅ Merged **Merged:** 7/12/2025 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `resolver-config-pub` --- ### 📝 Commits (1) - [`fa696d7`](https://github.com/hickory-dns/hickory-dns/commit/fa696d791d7bb449790e15764855d62adb0dddbc) resolver: make ResolverConfig fields public ### 📊 Changes **1 file changed** (+7 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `crates/resolver/src/config.rs` (+7 -6) </details> ### 📄 Description But make it non-exhaustive so that we can add new fields in the future. I think these fields have been pretty stable over time and there are no invariants that need to be maintained across fields, so there's not much justification for keeping it all private. Fixes #1899. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>