[PR #1703] [MERGED] Move logger setup code into binary #2531

New issue

Closed

opened 2026-03-16 10:06:28 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 10:06:28 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/1703
Author: @djc
Created: 4/26/2022
Status: ✅ Merged
Merged: 4/27/2022
Merged by: @bluejekyll

Base: main ← Head: server-logger

📝 Commits (1)

0d599b0 Move logger setup code into binary

📊 Changes

6 files changed (+89 additions, -105 deletions)

View changed files

📝 Cargo.lock (+0 -1)
📝 bin/Cargo.toml (+2 -1)
📝 bin/src/named.rs (+87 -4)
📝 crates/server/Cargo.toml (+0 -2)
📝 crates/server/src/lib.rs (+0 -2)
➖ crates/server/src/logger.rs (+0 -95)

📄 Description

I think the changes in #1701 don't quite make sense, here's a more radical take.

cc @Noah-Kennedy not sure if there was any reason not to go this route in your PR?

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/1703 **Author:** [@djc](https://github.com/djc) **Created:** 4/26/2022 **Status:** ✅ Merged **Merged:** 4/27/2022 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `main` ← **Head:** `server-logger` --- ### 📝 Commits (1) - [`0d599b0`](https://github.com/hickory-dns/hickory-dns/commit/0d599b0ffb0dea5a83b1e8509f79ea62883a07a6) Move logger setup code into binary ### 📊 Changes **6 files changed** (+89 additions, -105 deletions) <details> <summary>View changed files</summary> 📝 `Cargo.lock` (+0 -1) 📝 `bin/Cargo.toml` (+2 -1) 📝 `bin/src/named.rs` (+87 -4) 📝 `crates/server/Cargo.toml` (+0 -2) 📝 `crates/server/src/lib.rs` (+0 -2) ➖ `crates/server/src/logger.rs` (+0 -95) </details> ### 📄 Description I think the changes in #1701 don't quite make sense, here's a more radical take. cc @Noah-Kennedy not sure if there was any reason not to go this route in your PR? --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>