[PR #2394] [MERGED] proto: replace Borrow<Name> impl for LowerName with Deref #3011

New issue

Closed

opened 2026-03-16 11:20:24 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:20:24 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2394
Author: @djc
Created: 8/30/2024
Status: ✅ Merged
Merged: 8/30/2024
Merged by: @pvdrz

Base: main ← Head: lower-name-deref

📝 Commits (1)

3e18483 proto: replace Borrow impl for LowerName with Deref

📊 Changes

1 file changed (+5 additions, -3 deletions)

View changed files

📝 crates/proto/src/rr/lower_name.rs (+5 -3)

📄 Description

This is simpler to use and seems more idiomatic to me.

cc @pvdrz

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2394 **Author:** [@djc](https://github.com/djc) **Created:** 8/30/2024 **Status:** ✅ Merged **Merged:** 8/30/2024 **Merged by:** [@pvdrz](https://github.com/pvdrz) **Base:** `main` ← **Head:** `lower-name-deref` --- ### 📝 Commits (1) - [`3e18483`](https://github.com/hickory-dns/hickory-dns/commit/3e184837af0a1460b7a0b91740697e7429a8e901) proto: replace Borrow<Name> impl for LowerName with Deref ### 📊 Changes **1 file changed** (+5 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `crates/proto/src/rr/lower_name.rs` (+5 -3) </details> ### 📄 Description This is simpler to use and seems more idiomatic to me. cc @pvdrz --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>