[PR #3131] [MERGED] Improve DNSSEC APIs #3583

New issue

Closed

opened 2026-03-16 11:51:31 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:51:31 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/3131
Author: @djc
Created: 7/18/2025
Status: ✅ Merged
Merged: 7/21/2025
Merged by: @djc

Base: main ← Head: dnssec-server

📝 Commits (10+)

e889dc4 server: make LookupOptions fields public
abbcccd server: move lookup_options_for_edns() to LookupOptions::from_edns()
575b208 server: discard trivial setter
46afa86 server: simplify test constructor
e045ad1 server: simplify LookupOptions::from_edns()
1087b90 server: discard get_() prefixes
f834dd1 server: simplify DNSSEC handling when disabled
51ad48c Move DnssecSummary to proto crate
1478f4d server: simplify setting authoritative flag
e3c82cb server: hoist response-independent handling

📊 Changes

24 files changed (+185 additions, -245 deletions)

View changed files

📝 bin/tests/integration/authority_battery/dnssec.rs (+10 -10)
📝 bin/tests/integration/server_harness/mod.rs (+1 -1)
📝 crates/proto/src/dnssec/dnssec_dns_handle/mod.rs (+1 -1)
📝 crates/proto/src/dnssec/mod.rs (+35 -1)
📝 crates/proto/src/error.rs (+9 -14)
📝 crates/proto/src/xfer/dns_request.rs (+0 -9)
📝 crates/recursor/src/error.rs (+9 -11)
📝 crates/recursor/src/recursor.rs (+1 -1)
📝 crates/resolver/src/cache.rs (+1 -1)
📝 crates/server/src/authority/auth_lookup.rs (+1 -1)
📝 crates/server/src/authority/authority.rs (+24 -26)
📝 crates/server/src/authority/catalog.rs (+61 -88)
📝 crates/server/src/authority/message_response.rs (+1 -1)
📝 crates/server/src/authority/mod.rs (+0 -49)
📝 crates/server/src/server/response_handler.rs (+1 -1)
📝 crates/server/src/store/blocklist.rs (+2 -2)
📝 crates/server/src/store/file.rs (+4 -4)
📝 crates/server/src/store/forwarder.rs (+2 -2)
📝 crates/server/src/store/in_memory/inner.rs (+5 -5)
📝 crates/server/src/store/in_memory/mod.rs (+4 -4)

...and 4 more files

📄 Description

A fairly meandering route towards fixing #3011.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/3131 **Author:** [@djc](https://github.com/djc) **Created:** 7/18/2025 **Status:** ✅ Merged **Merged:** 7/21/2025 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `dnssec-server` --- ### 📝 Commits (10+) - [`e889dc4`](https://github.com/hickory-dns/hickory-dns/commit/e889dc484b98ead278a7833f7ad0cc3604b53dd8) server: make LookupOptions fields public - [`abbcccd`](https://github.com/hickory-dns/hickory-dns/commit/abbcccdd9d172a0a2e1e84dd177dc56bcdce2c8c) server: move lookup_options_for_edns() to LookupOptions::from_edns() - [`575b208`](https://github.com/hickory-dns/hickory-dns/commit/575b208c1969a840aac4b5eb091978954f6f326a) server: discard trivial setter - [`46afa86`](https://github.com/hickory-dns/hickory-dns/commit/46afa86392f551eeea9633a7de172c37ab3ce1e5) server: simplify test constructor - [`e045ad1`](https://github.com/hickory-dns/hickory-dns/commit/e045ad1842ff4de4ab35ccf69b6bdd1e8dc917ba) server: simplify LookupOptions::from_edns() - [`1087b90`](https://github.com/hickory-dns/hickory-dns/commit/1087b90b3f509f19f4c1b7780056e4caeaa789a1) server: discard get_() prefixes - [`f834dd1`](https://github.com/hickory-dns/hickory-dns/commit/f834dd13a0f817e4af9ca6767d085d323e972e7e) server: simplify DNSSEC handling when disabled - [`51ad48c`](https://github.com/hickory-dns/hickory-dns/commit/51ad48cfd5342ef0f09dbc7e0d60bf60d11be8fd) Move DnssecSummary to proto crate - [`1478f4d`](https://github.com/hickory-dns/hickory-dns/commit/1478f4d3f47eded7b9ed06e6c64941699f90d9b9) server: simplify setting authoritative flag - [`e3c82cb`](https://github.com/hickory-dns/hickory-dns/commit/e3c82cb2ef08f6a3e75ee0c3389ebbca560180d0) server: hoist response-independent handling ### 📊 Changes **24 files changed** (+185 additions, -245 deletions) <details> <summary>View changed files</summary> 📝 `bin/tests/integration/authority_battery/dnssec.rs` (+10 -10) 📝 `bin/tests/integration/server_harness/mod.rs` (+1 -1) 📝 `crates/proto/src/dnssec/dnssec_dns_handle/mod.rs` (+1 -1) 📝 `crates/proto/src/dnssec/mod.rs` (+35 -1) 📝 `crates/proto/src/error.rs` (+9 -14) 📝 `crates/proto/src/xfer/dns_request.rs` (+0 -9) 📝 `crates/recursor/src/error.rs` (+9 -11) 📝 `crates/recursor/src/recursor.rs` (+1 -1) 📝 `crates/resolver/src/cache.rs` (+1 -1) 📝 `crates/server/src/authority/auth_lookup.rs` (+1 -1) 📝 `crates/server/src/authority/authority.rs` (+24 -26) 📝 `crates/server/src/authority/catalog.rs` (+61 -88) 📝 `crates/server/src/authority/message_response.rs` (+1 -1) 📝 `crates/server/src/authority/mod.rs` (+0 -49) 📝 `crates/server/src/server/response_handler.rs` (+1 -1) 📝 `crates/server/src/store/blocklist.rs` (+2 -2) 📝 `crates/server/src/store/file.rs` (+4 -4) 📝 `crates/server/src/store/forwarder.rs` (+2 -2) 📝 `crates/server/src/store/in_memory/inner.rs` (+5 -5) 📝 `crates/server/src/store/in_memory/mod.rs` (+4 -4) _...and 4 more files_ </details> ### 📄 Description A fairly meandering route towards fixing #3011. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>