[PR #1528] [MERGED] Ensure doc tests are run in CI #2394

Closed
opened 2026-03-16 08:51:23 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/1528
Author: @bluejekyll
Created: 8/1/2021
Status: Merged
Merged: 8/2/2021
Merged by: @djc

Base: mainHead: test-doc-tests


📝 Commits (1)

  • 0d97ee7 Ensure doc tests are run in CI

📊 Changes

7 files changed (+56 additions, -19 deletions)

View changed files

📝 Makefile.toml (+15 -3)
📝 bin/Makefile.toml (+1 -0)
📝 crates/async-std-resolver/src/lib.rs (+4 -2)
📝 crates/client/src/lib.rs (+7 -7)
📝 crates/resolver/Makefile.toml (+1 -2)
📝 crates/resolver/src/lib.rs (+27 -5)
📝 util/Makefile.toml (+1 -0)

📄 Description

While looking at tests, apparently doc tests were not being run in CI, this fixes that.

Depends on #1527


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/1528 **Author:** [@bluejekyll](https://github.com/bluejekyll) **Created:** 8/1/2021 **Status:** ✅ Merged **Merged:** 8/2/2021 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `test-doc-tests` --- ### 📝 Commits (1) - [`0d97ee7`](https://github.com/hickory-dns/hickory-dns/commit/0d97ee79740b27e1705332b09a08173761357dd0) Ensure doc tests are run in CI ### 📊 Changes **7 files changed** (+56 additions, -19 deletions) <details> <summary>View changed files</summary> 📝 `Makefile.toml` (+15 -3) 📝 `bin/Makefile.toml` (+1 -0) 📝 `crates/async-std-resolver/src/lib.rs` (+4 -2) 📝 `crates/client/src/lib.rs` (+7 -7) 📝 `crates/resolver/Makefile.toml` (+1 -2) 📝 `crates/resolver/src/lib.rs` (+27 -5) 📝 `util/Makefile.toml` (+1 -0) </details> ### 📄 Description While looking at tests, apparently doc tests were not being run in CI, this fixes that. Depends on #1527 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-16 08:51:23 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/hickory-dns#2394
No description provided.