[PR #2351] [MERGED] Manifest cleanup #2978

New issue

Closed

opened 2026-03-16 11:18:30 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:18:30 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2351
Author: @djc
Created: 8/8/2024
Status: ✅ Merged
Merged: 8/8/2024
Merged by: @djc

Base: main ← Head: manifest-cleanup

📝 Commits (3)

3d4c209 Remove badges sections from Cargo manifests
3e23b4b Use one line per dependency for readability
57cb372 Rename serde-config feature to serde

📊 Changes

50 files changed (+160 additions, -274 deletions)

View changed files

📝 bin/Cargo.toml (+7 -27)
📝 crates/async-std-resolver/Cargo.toml (+2 -11)
📝 crates/client/Cargo.toml (+6 -25)
📝 crates/proto/Cargo.toml (+6 -25)
📝 crates/proto/src/rr/dns_class.rs (+2 -2)
📝 crates/proto/src/rr/dnssec/algorithm.rs (+2 -2)
📝 crates/proto/src/rr/dnssec/digest_type.rs (+2 -2)
📝 crates/proto/src/rr/dnssec/nsec3.rs (+2 -2)
📝 crates/proto/src/rr/dnssec/proof.rs (+2 -2)
📝 crates/proto/src/rr/dnssec/rdata/cdnskey.rs (+2 -2)
📝 crates/proto/src/rr/dnssec/rdata/cds.rs (+2 -2)
📝 crates/proto/src/rr/dnssec/rdata/dnskey.rs (+2 -2)
📝 crates/proto/src/rr/dnssec/rdata/ds.rs (+2 -2)
📝 crates/proto/src/rr/dnssec/rdata/key.rs (+6 -6)
📝 crates/proto/src/rr/dnssec/rdata/mod.rs (+2 -2)
📝 crates/proto/src/rr/dnssec/rdata/nsec.rs (+2 -2)
📝 crates/proto/src/rr/dnssec/rdata/nsec3.rs (+2 -2)
📝 crates/proto/src/rr/dnssec/rdata/nsec3param.rs (+2 -2)
📝 crates/proto/src/rr/dnssec/rdata/rrsig.rs (+2 -2)
📝 crates/proto/src/rr/dnssec/rdata/sig.rs (+2 -2)

...and 30 more files

📄 Description

Badges are deprecated (and no longer displayed on crates.io), so remove them
Spreading dependency features over multiple lines makes things harder to read IMO
Now that the implicit serde feature is suppressed, we no longer need a verbosified feature name for serde

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2351 **Author:** [@djc](https://github.com/djc) **Created:** 8/8/2024 **Status:** ✅ Merged **Merged:** 8/8/2024 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `manifest-cleanup` --- ### 📝 Commits (3) - [`3d4c209`](https://github.com/hickory-dns/hickory-dns/commit/3d4c209204ce0d20ee93147b3b47589e7945f988) Remove badges sections from Cargo manifests - [`3e23b4b`](https://github.com/hickory-dns/hickory-dns/commit/3e23b4b7c7322eb2d3873717084ac83727888719) Use one line per dependency for readability - [`57cb372`](https://github.com/hickory-dns/hickory-dns/commit/57cb3725dc2a217562b6f89b5664109a7e6a2e09) Rename serde-config feature to serde ### 📊 Changes **50 files changed** (+160 additions, -274 deletions) <details> <summary>View changed files</summary> 📝 `bin/Cargo.toml` (+7 -27) 📝 `crates/async-std-resolver/Cargo.toml` (+2 -11) 📝 `crates/client/Cargo.toml` (+6 -25) 📝 `crates/proto/Cargo.toml` (+6 -25) 📝 `crates/proto/src/rr/dns_class.rs` (+2 -2) 📝 `crates/proto/src/rr/dnssec/algorithm.rs` (+2 -2) 📝 `crates/proto/src/rr/dnssec/digest_type.rs` (+2 -2) 📝 `crates/proto/src/rr/dnssec/nsec3.rs` (+2 -2) 📝 `crates/proto/src/rr/dnssec/proof.rs` (+2 -2) 📝 `crates/proto/src/rr/dnssec/rdata/cdnskey.rs` (+2 -2) 📝 `crates/proto/src/rr/dnssec/rdata/cds.rs` (+2 -2) 📝 `crates/proto/src/rr/dnssec/rdata/dnskey.rs` (+2 -2) 📝 `crates/proto/src/rr/dnssec/rdata/ds.rs` (+2 -2) 📝 `crates/proto/src/rr/dnssec/rdata/key.rs` (+6 -6) 📝 `crates/proto/src/rr/dnssec/rdata/mod.rs` (+2 -2) 📝 `crates/proto/src/rr/dnssec/rdata/nsec.rs` (+2 -2) 📝 `crates/proto/src/rr/dnssec/rdata/nsec3.rs` (+2 -2) 📝 `crates/proto/src/rr/dnssec/rdata/nsec3param.rs` (+2 -2) 📝 `crates/proto/src/rr/dnssec/rdata/rrsig.rs` (+2 -2) 📝 `crates/proto/src/rr/dnssec/rdata/sig.rs` (+2 -2) _...and 30 more files_ </details> ### 📄 Description * Badges are deprecated (and no longer displayed on crates.io), so remove them * Spreading dependency features over multiple lines makes things harder to read IMO * Now that the implicit serde feature is suppressed, we no longer need a verbosified feature name for `serde` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>