[PR #1475] [CLOSED] 1445 part2 #2351

New issue

Closed

opened 2026-03-16 08:49:12 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 08:49:12 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/1475
Author: @lentalamp
Created: 5/1/2021
Status: ❌ Closed

Base: main ← Head: 1445-part2

📝 Commits (3)

08768ef 1445 Replace all min & max constructs with clamp
c6a9e56 1445 Replace all min & max constructs with clamp #1473
a4780c9 removed .max(0), unnecessary with u32's

📊 Changes

16 files changed (+18 additions, -19 deletions)

View changed files

📝 .github/workflows/test.yml (+1 -1)
📝 README.md (+1 -1)
📝 bin/README.md (+1 -1)
📝 crates/async-std-resolver/README.md (+1 -1)
📝 crates/client/README.md (+1 -1)
📝 crates/https/README.md (+1 -1)
📝 crates/native-tls/README.md (+1 -1)
📝 crates/openssl/README.md (+1 -1)
📝 crates/proto/README.md (+1 -1)
📝 crates/proto/src/https/https_client_stream.rs (+3 -3)
📝 crates/proto/src/https/https_server.rs (+1 -1)
📝 crates/proto/src/xfer/dns_response.rs (+1 -1)
📝 crates/resolver/README.md (+1 -1)
📝 crates/resolver/src/dns_lru.rs (+1 -2)
📝 crates/rustls/README.md (+1 -1)
📝 crates/server/README.md (+1 -1)

📄 Description

Building on top of #1473, I found one more place where min().max() construct could be replaced.

The simplest solution is not to use clamp(), but to remove the .max(0) as it is unnecessary on a u32.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/1475 **Author:** [@lentalamp](https://github.com/lentalamp) **Created:** 5/1/2021 **Status:** ❌ Closed **Base:** `main` ← **Head:** `1445-part2` --- ### 📝 Commits (3) - [`08768ef`](https://github.com/hickory-dns/hickory-dns/commit/08768ef5132528d96ab2de5c1474610c7c70ba97) 1445 Replace all min & max constructs with clamp - [`c6a9e56`](https://github.com/hickory-dns/hickory-dns/commit/c6a9e56d24511b3dadc3725cb525232a38ac87bb) 1445 Replace all min & max constructs with clamp #1473 - [`a4780c9`](https://github.com/hickory-dns/hickory-dns/commit/a4780c954a6a7db72cb5c6fad838cbd127d5377d) removed .max(0), unnecessary with u32's ### 📊 Changes **16 files changed** (+18 additions, -19 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/test.yml` (+1 -1) 📝 `README.md` (+1 -1) 📝 `bin/README.md` (+1 -1) 📝 `crates/async-std-resolver/README.md` (+1 -1) 📝 `crates/client/README.md` (+1 -1) 📝 `crates/https/README.md` (+1 -1) 📝 `crates/native-tls/README.md` (+1 -1) 📝 `crates/openssl/README.md` (+1 -1) 📝 `crates/proto/README.md` (+1 -1) 📝 `crates/proto/src/https/https_client_stream.rs` (+3 -3) 📝 `crates/proto/src/https/https_server.rs` (+1 -1) 📝 `crates/proto/src/xfer/dns_response.rs` (+1 -1) 📝 `crates/resolver/README.md` (+1 -1) 📝 `crates/resolver/src/dns_lru.rs` (+1 -2) 📝 `crates/rustls/README.md` (+1 -1) 📝 `crates/server/README.md` (+1 -1) </details> ### 📄 Description Building on top of #1473, I found one more place where min().max() construct could be replaced. The simplest solution is not to use clamp(), but to remove the .max(0) as it is unnecessary on a u32. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>