[PR #2328] [MERGED] resolver: Make QuicSocketBinder as public as RuntimeProvider #2955

New issue

Closed

opened 2026-03-16 11:17:25 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:17:25 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2328
Author: @mokeyish
Created: 7/27/2024
Status: ✅ Merged
Merged: 7/27/2024
Merged by: @djc

Base: main ← Head: patch-2

📝 Commits (1)

e684d55 resolver: Make QuicSocketBinder as public as RuntimeProvider/ConnectionProvider

📊 Changes

2 files changed (+4 additions, -0 deletions)

View changed files

📝 crates/resolver/src/name_server/connection_provider.rs (+2 -0)
📝 crates/resolver/src/name_server/mod.rs (+2 -0)

📄 Description

This is so that the quic_binder can be overridden externally.

#[cfg(any(feature = "dns-over-quic", feature = "dns-over-h3"))]
fn quic_binder(&self) -> Option<&dyn QuicSocketBinder> {
    Some(&TokioQuicSocketBinder)
}

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2328 **Author:** [@mokeyish](https://github.com/mokeyish) **Created:** 7/27/2024 **Status:** ✅ Merged **Merged:** 7/27/2024 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `patch-2` --- ### 📝 Commits (1) - [`e684d55`](https://github.com/hickory-dns/hickory-dns/commit/e684d551efecc5283e03cd42a9bec09a65bf2104) resolver: Make QuicSocketBinder as public as RuntimeProvider/ConnectionProvider ### 📊 Changes **2 files changed** (+4 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `crates/resolver/src/name_server/connection_provider.rs` (+2 -0) 📝 `crates/resolver/src/name_server/mod.rs` (+2 -0) </details> ### 📄 Description This is so that the quic_binder can be overridden externally. ```rs #[cfg(any(feature = "dns-over-quic", feature = "dns-over-h3"))] fn quic_binder(&self) -> Option<&dyn QuicSocketBinder> { Some(&TokioQuicSocketBinder) } ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>