[PR #2955] [MERGED] Use separate database files in SQLite tests #3447

New issue

Closed

opened 2026-03-16 11:44:10 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:44:10 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2955
Author: @divergentdave
Created: 4/29/2025
Status: ✅ Merged
Merged: 4/29/2025
Merged by: @divergentdave

Base: main ← Head: david/metrics-test-separate-db

📝 Commits (1)

34a5707 Use separate database files in SQLite tests

📊 Changes

2 files changed (+75 additions, -1 deletions)

View changed files

📝 bin/tests/integration/named_metrics_tests.rs (+10 -1)
➕ tests/test-data/test_configs/dnssec_with_update_2.toml (+65 -0)

📄 Description

I ran into issues running tests locally, because two different SQLite integration tests are using the same config file, and thus the same database file. This PR splits them up, and adds database cleanup to the second. This isn't as much of an issue in CI because the core count is lower, and thus these tests don't overlap there.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2955 **Author:** [@divergentdave](https://github.com/divergentdave) **Created:** 4/29/2025 **Status:** ✅ Merged **Merged:** 4/29/2025 **Merged by:** [@divergentdave](https://github.com/divergentdave) **Base:** `main` ← **Head:** `david/metrics-test-separate-db` --- ### 📝 Commits (1) - [`34a5707`](https://github.com/hickory-dns/hickory-dns/commit/34a57071664f60deb7f69307ec7f36cb3fb28e6b) Use separate database files in SQLite tests ### 📊 Changes **2 files changed** (+75 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `bin/tests/integration/named_metrics_tests.rs` (+10 -1) ➕ `tests/test-data/test_configs/dnssec_with_update_2.toml` (+65 -0) </details> ### 📄 Description I ran into issues running tests locally, because two different SQLite integration tests are using the same config file, and thus the same database file. This PR splits them up, and adds database cleanup to the second. This isn't as much of an issue in CI because the core count is lower, and thus these tests don't overlap there. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>