[PR #1449] [MERGED] Move other proto crates into proto #2328

New issue

Closed

opened 2026-03-16 08:47:51 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 08:47:51 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/1449
Author: @bluejekyll
Created: 4/12/2021
Status: ✅ Merged
Merged: 4/26/2021
Merged by: @bluejekyll

Base: main ← Head: move-other-proto-crates-into-proto

📝 Commits (8)

ccd0505 move rustls crate into proto
427f70f move https impls into proto
06def0b move native-tls into proto
1553a56 move openssl into proto
81abd18 fix tls in server_future_tests
c737700 reexport proto impls and deprecate old crates
4c53cd5 fix skip crate list
26a30f3 fix dns-over-tls tests

📊 Changes

56 files changed (+355 additions, -369 deletions)

View changed files

📝 Cargo.lock (+10 -50)
📝 Cargo.toml (+5 -5)
📝 Makefile.toml (+7 -7)
📝 bin/Cargo.toml (+4 -8)
📝 bin/tests/named_https_tests.rs (+1 -1)
📝 bin/tests/named_openssl_tests.rs (+3 -3)
📝 bin/tests/named_rustls_tests.rs (+1 -1)
📝 bin/tests/named_tests.rs (+1 -1)
📝 crates/client/Cargo.toml (+4 -4)
📝 crates/client/src/https_client_connection.rs (+1 -1)
📝 crates/https/Cargo.toml (+1 -20)
📝 crates/https/src/lib.rs (+3 -18)
📝 crates/native-tls/Cargo.toml (+1 -13)
📝 crates/native-tls/src/lib.rs (+3 -9)
📝 crates/openssl/Cargo.toml (+1 -10)
📝 crates/openssl/src/lib.rs (+9 -21)
📝 crates/proto/Cargo.toml (+22 -1)
📝 crates/proto/src/https/error.rs (+3 -2)
📝 crates/proto/src/https/https_client_stream.rs (+12 -14)
📝 crates/proto/src/https/https_server.rs (+5 -5)

...and 36 more files

📄 Description

@djc this is inline I think with our discussion on the number of crates. I think I like collapsing them all into the proto crate.

If this initial change looks good, then I will perform similar moves for OpenSSL and HTTPS.

fixes: #1446

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/1449 **Author:** [@bluejekyll](https://github.com/bluejekyll) **Created:** 4/12/2021 **Status:** ✅ Merged **Merged:** 4/26/2021 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `main` ← **Head:** `move-other-proto-crates-into-proto` --- ### 📝 Commits (8) - [`ccd0505`](https://github.com/hickory-dns/hickory-dns/commit/ccd0505bc555b6c9c7bfc17a32808b5a8e2e7f1f) move rustls crate into proto - [`427f70f`](https://github.com/hickory-dns/hickory-dns/commit/427f70fddc4f8a87d62465e7836a4719258cf716) move https impls into proto - [`06def0b`](https://github.com/hickory-dns/hickory-dns/commit/06def0b3757a5648803f5c51479c2afe273d7dc1) move native-tls into proto - [`1553a56`](https://github.com/hickory-dns/hickory-dns/commit/1553a5641e6a2d05876bb9bda1dfae3e610f00ef) move openssl into proto - [`81abd18`](https://github.com/hickory-dns/hickory-dns/commit/81abd1842e362b2169e856391c13836e411138a2) fix tls in server_future_tests - [`c737700`](https://github.com/hickory-dns/hickory-dns/commit/c7377007a3f277fba2dd697252e9bfcf2cb71ed6) reexport proto impls and deprecate old crates - [`4c53cd5`](https://github.com/hickory-dns/hickory-dns/commit/4c53cd56e344345323bbd564acca21568bf05bd9) fix skip crate list - [`26a30f3`](https://github.com/hickory-dns/hickory-dns/commit/26a30f3eb074f9fafebb4bea2b618cbd5edc4047) fix dns-over-tls tests ### 📊 Changes **56 files changed** (+355 additions, -369 deletions) <details> <summary>View changed files</summary> 📝 `Cargo.lock` (+10 -50) 📝 `Cargo.toml` (+5 -5) 📝 `Makefile.toml` (+7 -7) 📝 `bin/Cargo.toml` (+4 -8) 📝 `bin/tests/named_https_tests.rs` (+1 -1) 📝 `bin/tests/named_openssl_tests.rs` (+3 -3) 📝 `bin/tests/named_rustls_tests.rs` (+1 -1) 📝 `bin/tests/named_tests.rs` (+1 -1) 📝 `crates/client/Cargo.toml` (+4 -4) 📝 `crates/client/src/https_client_connection.rs` (+1 -1) 📝 `crates/https/Cargo.toml` (+1 -20) 📝 `crates/https/src/lib.rs` (+3 -18) 📝 `crates/native-tls/Cargo.toml` (+1 -13) 📝 `crates/native-tls/src/lib.rs` (+3 -9) 📝 `crates/openssl/Cargo.toml` (+1 -10) 📝 `crates/openssl/src/lib.rs` (+9 -21) 📝 `crates/proto/Cargo.toml` (+22 -1) 📝 `crates/proto/src/https/error.rs` (+3 -2) 📝 `crates/proto/src/https/https_client_stream.rs` (+12 -14) 📝 `crates/proto/src/https/https_server.rs` (+5 -5) _...and 36 more files_ </details> ### 📄 Description @djc this is inline I think with our discussion on the number of crates. I think I like collapsing them all into the proto crate. If this initial change looks good, then I will perform similar moves for OpenSSL and HTTPS. fixes: #1446 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>