[PR #2300] [MERGED] recursor: fix DNSSEC validation of `NS somedomain.com.` #2933

New issue

Closed

opened 2026-03-16 11:16:03 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:16:03 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2300
Author: @japaric
Created: 7/9/2024
Status: ✅ Merged
Merged: 7/10/2024
Merged by: @japaric

Base: main ← Head: ja-gh2299

📝 Commits (4)

c657bc6 conformance: add regression test for #2299
78fcb84 conformance: add regression test for #2285
a563a7f do not send NS queries to the parent zone when DO=1
75d7fde bypass cache if it does not include DNSSEC records and query is DO=1

📊 Changes

3 files changed (+126 additions, -5 deletions)

View changed files

📝 conformance/packages/conformance-tests/src/resolver/dnssec.rs (+1 -0)
➕ conformance/packages/conformance-tests/src/resolver/dnssec/regression.rs (+95 -0)
📝 crates/recursor/src/recursor_dns_handle.rs (+30 -5)

📄 Description

more details can be found in the commit messages

fixes #2299
fixes #2285

(2299 was the root of the DNSSEC validation problem. IOW, 2285 was another symptom of the 2299 bug)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2300 **Author:** [@japaric](https://github.com/japaric) **Created:** 7/9/2024 **Status:** ✅ Merged **Merged:** 7/10/2024 **Merged by:** [@japaric](https://github.com/japaric) **Base:** `main` ← **Head:** `ja-gh2299` --- ### 📝 Commits (4) - [`c657bc6`](https://github.com/hickory-dns/hickory-dns/commit/c657bc6cf50d5d1ff130a8c4e064b2ee950a27c4) conformance: add regression test for #2299 - [`78fcb84`](https://github.com/hickory-dns/hickory-dns/commit/78fcb84cc0deed3e93950b51e2f2ad404371863a) conformance: add regression test for #2285 - [`a563a7f`](https://github.com/hickory-dns/hickory-dns/commit/a563a7f58ccfeeb47dd1d8b25db2523010c1d75a) do not send NS queries to the parent zone when DO=1 - [`75d7fde`](https://github.com/hickory-dns/hickory-dns/commit/75d7fdecca1df96d80d72749de02ae32eaedc7f4) bypass cache if it does not include DNSSEC records and query is DO=1 ### 📊 Changes **3 files changed** (+126 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `conformance/packages/conformance-tests/src/resolver/dnssec.rs` (+1 -0) ➕ `conformance/packages/conformance-tests/src/resolver/dnssec/regression.rs` (+95 -0) 📝 `crates/recursor/src/recursor_dns_handle.rs` (+30 -5) </details> ### 📄 Description more details can be found in the commit messages fixes #2299 fixes #2285 (2299 was the root of the DNSSEC validation problem. IOW, 2285 was another symptom of the 2299 bug) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>