[PR #2942] [MERGED] Use Place in `TBS::new()` #3435

New issue

Closed

opened 2026-03-16 11:43:37 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:43:37 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2942
Author: @divergentdave
Created: 4/18/2025
Status: ✅ Merged
Merged: 4/18/2025
Merged by: @divergentdave

Base: main ← Head: david/tbs-place

📝 Commits (2)

034d798 Remove assertions in TBS
6fa27c8 Use Place in TBS encoding

📊 Changes

1 file changed (+32 additions, -46 deletions)

View changed files

📝 crates/proto/src/dnssec/tbs.rs (+32 -46)

📄 Description

This addresses a FIXME and a TODO in tbs.rs. Closes #2933.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2942 **Author:** [@divergentdave](https://github.com/divergentdave) **Created:** 4/18/2025 **Status:** ✅ Merged **Merged:** 4/18/2025 **Merged by:** [@divergentdave](https://github.com/divergentdave) **Base:** `main` ← **Head:** `david/tbs-place` --- ### 📝 Commits (2) - [`034d798`](https://github.com/hickory-dns/hickory-dns/commit/034d798bb7a63429ade458e9a4af3a023469b7c0) Remove assertions in TBS - [`6fa27c8`](https://github.com/hickory-dns/hickory-dns/commit/6fa27c829cb57ab539a23ed9c1fba3e17872f6e4) Use Place in TBS encoding ### 📊 Changes **1 file changed** (+32 additions, -46 deletions) <details> <summary>View changed files</summary> 📝 `crates/proto/src/dnssec/tbs.rs` (+32 -46) </details> ### 📄 Description This addresses a FIXME and a TODO in `tbs.rs`. Closes #2933. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>