[PR #1364] [CLOSED] Preserve EDNS OPT record in a response if truncation occurs #2252

New issue

Closed

opened 2026-03-16 08:12:42 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 08:12:42 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/1364
Author: @vlad20012
Created: 1/21/2021
Status: ❌ Closed

Base: main ← Head: edns-truncation

📝 Commits (1)

0e6682a Preserve EDNS OPT record in a response if truncation occurs

📊 Changes

4 files changed (+115 additions, -16 deletions)

View changed files

📝 crates/proto/src/op/edns.rs (+13 -0)
📝 crates/proto/src/op/message.rs (+20 -4)
📝 crates/proto/src/serialize/binary/encoder.rs (+17 -2)
📝 crates/server/src/authority/message_response.rs (+65 -10)

📄 Description

According to RFC 6891

The minimal response MUST be the DNS header, question section, and an
OPT record. This MUST also occur when a truncated response (using
the DNS header's TC bit) is returned.

Hence, we must preserve EDNS OPT record in an answer when truncation occurs

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/1364 **Author:** [@vlad20012](https://github.com/vlad20012) **Created:** 1/21/2021 **Status:** ❌ Closed **Base:** `main` ← **Head:** `edns-truncation` --- ### 📝 Commits (1) - [`0e6682a`](https://github.com/hickory-dns/hickory-dns/commit/0e6682aa924d47ee0414957e68635f5f691758ef) Preserve EDNS OPT record in a response if truncation occurs ### 📊 Changes **4 files changed** (+115 additions, -16 deletions) <details> <summary>View changed files</summary> 📝 `crates/proto/src/op/edns.rs` (+13 -0) 📝 `crates/proto/src/op/message.rs` (+20 -4) 📝 `crates/proto/src/serialize/binary/encoder.rs` (+17 -2) 📝 `crates/server/src/authority/message_response.rs` (+65 -10) </details> ### 📄 Description According to [RFC 6891](https://tools.ietf.org/html/rfc6891#section-7) > The minimal response MUST be the DNS header, question section, and **an OPT record**. This MUST also occur when a truncated response (using the DNS header's TC bit) is returned. Hence, we must preserve EDNS OPT record in an answer when truncation occurs --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>