[PR #2280] [MERGED] Add test to check cache hit with DO bit #2921

Closed
opened 2026-03-16 11:15:31 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2280
Author: @justahero
Created: 7/3/2024
Status: Merged
Merged: 7/4/2024
Merged by: @japaric

Base: mainHead: sz-test-caching-behaviour-do-queries


📝 Commits (2)

  • 5ea1b0e Add test to check cache hit with DO bit
  • 6568398 Add test to check cache behavior

📊 Changes

2 files changed (+68 additions, -0 deletions)

View changed files

📝 conformance/packages/conformance-tests/src/resolver/dnssec/rfc4035/section_3/section_3_2.rs (+30 -0)
📝 conformance/packages/conformance-tests/src/resolver/dnssec/rfc4035/section_4/section_4_5.rs (+38 -0)

📄 Description

This adds the companion test to check that a previously cached request with DO bit set to 0 followed by a second request with DO bit set to 1 returns all DNSSEC records, answer + RRSIG, hitting the cache.

  • adding test to specifically check cache behaviour

Closes #2276


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2280 **Author:** [@justahero](https://github.com/justahero) **Created:** 7/3/2024 **Status:** ✅ Merged **Merged:** 7/4/2024 **Merged by:** [@japaric](https://github.com/japaric) **Base:** `main` ← **Head:** `sz-test-caching-behaviour-do-queries` --- ### 📝 Commits (2) - [`5ea1b0e`](https://github.com/hickory-dns/hickory-dns/commit/5ea1b0e5c684ac74f2728b3f043f2612abfecdfe) Add test to check cache hit with DO bit - [`6568398`](https://github.com/hickory-dns/hickory-dns/commit/6568398ea36366e536f29691fb1b42c5d175a10f) Add test to check cache behavior ### 📊 Changes **2 files changed** (+68 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `conformance/packages/conformance-tests/src/resolver/dnssec/rfc4035/section_3/section_3_2.rs` (+30 -0) 📝 `conformance/packages/conformance-tests/src/resolver/dnssec/rfc4035/section_4/section_4_5.rs` (+38 -0) </details> ### 📄 Description This adds the companion test to check that a previously cached request with DO bit set to `0` followed by a second request with DO bit set to `1` returns all DNSSEC records, answer + RRSIG, hitting the cache. * adding test to specifically check cache behaviour Closes #2276 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-16 11:15:31 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/hickory-dns#2921
No description provided.