[PR #2972] [MERGED] Clean up after removal of SOA referrals #3458

New issue

Closed

opened 2026-03-16 11:44:43 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:44:43 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2972
Author: @divergentdave
Created: 5/6/2025
Status: ✅ Merged
Merged: 5/6/2025
Merged by: @divergentdave

Base: main ← Head: david/remove-forward-data-name

📝 Commits (2)

eb27833 Remove SOA name from ForwardData
b11fc63 Rename ForwardData to AuthorityData

📊 Changes

5 files changed (+25 additions, -30 deletions)

View changed files

📝 crates/proto/src/error.rs (+11 -15)
📝 crates/proto/src/lib.rs (+1 -1)
📝 crates/recursor/src/error.rs (+11 -12)
📝 crates/recursor/src/recursor.rs (+1 -1)
📝 crates/server/src/authority/mod.rs (+1 -1)

📄 Description

This removes the unused name field from the ForwardData struct, and then renames the struct (and related ErrorKind variant) to reflect that it is now only used for NXDOMAIN and no data responses. Closes #2921.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2972 **Author:** [@divergentdave](https://github.com/divergentdave) **Created:** 5/6/2025 **Status:** ✅ Merged **Merged:** 5/6/2025 **Merged by:** [@divergentdave](https://github.com/divergentdave) **Base:** `main` ← **Head:** `david/remove-forward-data-name` --- ### 📝 Commits (2) - [`eb27833`](https://github.com/hickory-dns/hickory-dns/commit/eb278334d8f61e0f7c7362e21df25d7cd0d1d469) Remove SOA name from ForwardData - [`b11fc63`](https://github.com/hickory-dns/hickory-dns/commit/b11fc637b15f894a376da42c0d4a465649f873df) Rename ForwardData to AuthorityData ### 📊 Changes **5 files changed** (+25 additions, -30 deletions) <details> <summary>View changed files</summary> 📝 `crates/proto/src/error.rs` (+11 -15) 📝 `crates/proto/src/lib.rs` (+1 -1) 📝 `crates/recursor/src/error.rs` (+11 -12) 📝 `crates/recursor/src/recursor.rs` (+1 -1) 📝 `crates/server/src/authority/mod.rs` (+1 -1) </details> ### 📄 Description This removes the unused `name` field from the `ForwardData` struct, and then renames the struct (and related ErrorKind variant) to reflect that it is now only used for NXDOMAIN and no data responses. Closes #2921. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>