[PR #1386] [MERGED] proto: minor cleanups #2280

New issue

Closed

opened 2026-03-16 08:45:05 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 08:45:05 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/1386
Author: @leshow
Created: 2/24/2021
Status: ✅ Merged
Merged: 3/2/2021
Merged by: @djc

Base: main ← Head: proto_minor_cleanups

📝 Commits (2)

f7c0428 proto: minor cleanups
301ed99 proto: SerialMessage tweaks

📊 Changes

4 files changed (+43 additions, -36 deletions)

View changed files

📝 crates/proto/src/op/message.rs (+17 -21)
📝 crates/proto/src/rr/domain/try_parse_ip.rs (+6 -13)
📝 crates/proto/src/tcp/tcp_stream.rs (+1 -1)
📝 crates/proto/src/xfer/serial_message.rs (+19 -1)

📄 Description

I was putzing around in proto and saw some stuff written in an older style I figured I may as well clean up.

Is there a reason the IntoName trait couldn't just be Into<Name>? The other question I had was around TryParseIp, which almost seems like it should be a TryInto<RData> just judging by it's method, in any case I didn't grasp the reason why TryParseIp for Name is None.

All of this is very non-critical, just wondering if we can't move to some std traits for a few of these things.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/1386 **Author:** [@leshow](https://github.com/leshow) **Created:** 2/24/2021 **Status:** ✅ Merged **Merged:** 3/2/2021 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `proto_minor_cleanups` --- ### 📝 Commits (2) - [`f7c0428`](https://github.com/hickory-dns/hickory-dns/commit/f7c04280fce378442ca9ebbf1ccc61271b5f5741) proto: minor cleanups - [`301ed99`](https://github.com/hickory-dns/hickory-dns/commit/301ed99bb912502467b909ca58d511d198172ffa) proto: SerialMessage tweaks ### 📊 Changes **4 files changed** (+43 additions, -36 deletions) <details> <summary>View changed files</summary> 📝 `crates/proto/src/op/message.rs` (+17 -21) 📝 `crates/proto/src/rr/domain/try_parse_ip.rs` (+6 -13) 📝 `crates/proto/src/tcp/tcp_stream.rs` (+1 -1) 📝 `crates/proto/src/xfer/serial_message.rs` (+19 -1) </details> ### 📄 Description I was putzing around in `proto` and saw some stuff written in an older style I figured I may as well clean up. Is there a reason the `IntoName` trait couldn't just be `Into<Name>`? The other question I had was around `TryParseIp`, which almost seems like it should be a `TryInto<RData>` just judging by it's method, in any case I didn't grasp the reason why `TryParseIp for Name` is `None`. All of this is very non-critical, just wondering if we can't move to some std traits for a few of these things. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>