[PR #2765] [MERGED] Preserve DNSKEY flags field #3304

New issue

Closed

opened 2026-03-16 11:36:18 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:36:18 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2765
Author: @divergentdave
Created: 2/10/2025
Status: ✅ Merged
Merged: 2/11/2025
Merged by: @divergentdave

Base: main ← Head: david/preserve-dnskey-flags

📝 Commits (2)

fd22eb1 Preserve DNSKEY flags field
8fa59cf Allow any DNSKEY flags value in zone files

📊 Changes

2 files changed (+36 additions, -46 deletions)

View changed files

📝 crates/proto/src/dnssec/rdata/dnskey.rs (+30 -25)
📝 crates/proto/src/serialize/txt/rdata_parsers/dnskey.rs (+6 -21)

📄 Description

This PR preserves the flags field of DNSKEY records as-is. This avoids potential forwards-compatibility issues with records that have other flag bits. The DS digest computation depends on the full flags field, plus we should avoid rewriting records with unrecognized flags set as they transit a resolver.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2765 **Author:** [@divergentdave](https://github.com/divergentdave) **Created:** 2/10/2025 **Status:** ✅ Merged **Merged:** 2/11/2025 **Merged by:** [@divergentdave](https://github.com/divergentdave) **Base:** `main` ← **Head:** `david/preserve-dnskey-flags` --- ### 📝 Commits (2) - [`fd22eb1`](https://github.com/hickory-dns/hickory-dns/commit/fd22eb187298cd3f1d060b9f8e2ecec5f5a155b4) Preserve DNSKEY flags field - [`8fa59cf`](https://github.com/hickory-dns/hickory-dns/commit/8fa59cfae3201746a891cb0b8d4bf2d84b2d23c3) Allow any DNSKEY flags value in zone files ### 📊 Changes **2 files changed** (+36 additions, -46 deletions) <details> <summary>View changed files</summary> 📝 `crates/proto/src/dnssec/rdata/dnskey.rs` (+30 -25) 📝 `crates/proto/src/serialize/txt/rdata_parsers/dnskey.rs` (+6 -21) </details> ### 📄 Description This PR preserves the flags field of DNSKEY records as-is. This avoids potential forwards-compatibility issues with records that have other flag bits. The DS digest computation depends on the full flags field, plus we should avoid rewriting records with unrecognized flags set as they transit a resolver. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>