[PR #1028] [CLOSED] SUGGESTION: Allow CNAME records on A/AAAA lookups #1885

New issue

Closed

opened 2026-03-16 02:52:36 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 02:52:36 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/1028
Author: @balboah
Created: 2/24/2020
Status: ❌ Closed

Base: master ← Head: fix/missing_cname_records

📝 Commits (4)

5d9e60e Allow CNAME records on A/AAAA lookups
94eb139 rustfmt
ffc6e51 Fix cname chain min TTL test
4256757 Fix lookup integration tests & max query depth

📊 Changes

3 files changed (+45 additions, -38 deletions)

View changed files

📝 .rustfmt.toml (+1 -0)
📝 crates/resolver/src/lookup_state.rs (+26 -33)
📝 tests/integration-tests/tests/lookup_tests.rs (+18 -5)

📄 Description

This resolves my specific issue mentioned in #184. But I haven't considered what other records that should allow CNAME records and the risk involved with returning too many records or breaking other parts of trust-dns.

@bluejekyll

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/1028 **Author:** [@balboah](https://github.com/balboah) **Created:** 2/24/2020 **Status:** ❌ Closed **Base:** `master` ← **Head:** `fix/missing_cname_records` --- ### 📝 Commits (4) - [`5d9e60e`](https://github.com/hickory-dns/hickory-dns/commit/5d9e60ec0ba584fd15b824a64b85612641acbd9a) Allow CNAME records on A/AAAA lookups - [`94eb139`](https://github.com/hickory-dns/hickory-dns/commit/94eb139f497f0b2f1570d2b341ff68aaa8376958) rustfmt - [`ffc6e51`](https://github.com/hickory-dns/hickory-dns/commit/ffc6e5130a30737c3f51bc45b9efdad1521caa67) Fix cname chain min TTL test - [`4256757`](https://github.com/hickory-dns/hickory-dns/commit/425675720dfe93e8244d6d11e45d81ae2fe0392d) Fix lookup integration tests & max query depth ### 📊 Changes **3 files changed** (+45 additions, -38 deletions) <details> <summary>View changed files</summary> 📝 `.rustfmt.toml` (+1 -0) 📝 `crates/resolver/src/lookup_state.rs` (+26 -33) 📝 `tests/integration-tests/tests/lookup_tests.rs` (+18 -5) </details> ### 📄 Description This resolves my specific issue mentioned in #184. But I haven't considered what other records that should allow CNAME records and the risk involved with returning too many records or breaking other parts of trust-dns. @bluejekyll --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>