[PR #482] [MERGED] resolver: Refactor `LookupFuture` to remove `task::current().notify()`. #1473

New issue

Closed

opened 2026-03-16 02:08:23 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 02:08:23 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/482
Author: @hawkw
Created: 5/21/2018
Status: ✅ Merged
Merged: 5/25/2018
Merged by: @bluejekyll

Base: master ← Head: eliza/no-unpark-lookups

📝 Commits (6)

199ae2e resolver: Refactor Future implementation for LookupIpFuture
c4ba57f Merge branch 'master' into eliza/no-unpark
017d1c0 resolver: Improve comments in LookupIpFuture
fa3051b resolver: Refactor LookupFuture to remove task::current().notify().
6c8aed2 Merge branch 'master' into eliza/no-unpark-lookups
6dab5da Merge branch 'master' into eliza/no-unpark-lookups

📊 Changes

1 file changed (+39 additions, -32 deletions)

View changed files

📝 resolver/src/lookup.rs (+39 -32)

📄 Description

Depends on #480.

This is essentially the same set of changes as #480 but applied to
lookup::LookupFuture. I thought it was good for these similar futures to be
implemented in a consistent style.

Potentially, I think there is some code that's common between LookupIpFuture
and LookupFuture that could be factored out; I haven't yet come up with a
way to do this that doesn't introduce more complexity, but I'm sure it'sa
possible.

Signed-off-by: Eliza Weisman eliza@buoyant.io

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/482 **Author:** [@hawkw](https://github.com/hawkw) **Created:** 5/21/2018 **Status:** ✅ Merged **Merged:** 5/25/2018 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `master` ← **Head:** `eliza/no-unpark-lookups` --- ### 📝 Commits (6) - [`199ae2e`](https://github.com/hickory-dns/hickory-dns/commit/199ae2e0347ff5a0db9341400199769b92911959) resolver: Refactor Future implementation for LookupIpFuture - [`c4ba57f`](https://github.com/hickory-dns/hickory-dns/commit/c4ba57f823d1e0252f91423a26b9ae8aa347cacd) Merge branch 'master' into eliza/no-unpark - [`017d1c0`](https://github.com/hickory-dns/hickory-dns/commit/017d1c0242895e4c44c68c1de78088c1ff05fee3) resolver: Improve comments in `LookupIpFuture` - [`fa3051b`](https://github.com/hickory-dns/hickory-dns/commit/fa3051b22684e3984f13ceb220d16d2a6fc85e60) resolver: Refactor `LookupFuture` to remove `task::current().notify()`. - [`6c8aed2`](https://github.com/hickory-dns/hickory-dns/commit/6c8aed23416ad1543a1ca88f63d3a18368c10c9d) Merge branch 'master' into eliza/no-unpark-lookups - [`6dab5da`](https://github.com/hickory-dns/hickory-dns/commit/6dab5da50d8f12bc18898cbc6a3548c9f1517724) Merge branch 'master' into eliza/no-unpark-lookups ### 📊 Changes **1 file changed** (+39 additions, -32 deletions) <details> <summary>View changed files</summary> 📝 `resolver/src/lookup.rs` (+39 -32) </details> ### 📄 Description Depends on #480. This is essentially the same set of changes as #480 but applied to `lookup::LookupFuture`. I thought it was good for these similar futures to be implemented in a consistent style. Potentially, I think there is some code that's common between `LookupIpFuture` and `LookupFuture` that could be factored out; I haven't yet come up with a way to do this that doesn't introduce _more_ complexity, but I'm sure it'sa possible. Signed-off-by: Eliza Weisman <eliza@buoyant.io> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>