[PR #1431] [MERGED] Fix Windows build without system-config feature #2316

New issue

Closed

opened 2026-03-16 08:47:18 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 08:47:18 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/1431
Author: @stephank
Created: 4/1/2021
Status: ✅ Merged
Merged: 4/1/2021
Merged by: @djc

Base: main ← Head: main

📝 Commits (1)

86820e4 Fix Windows build without system-config feature

📊 Changes

1 file changed (+2 additions, -1 deletions)

View changed files

📝 crates/resolver/src/error.rs (+2 -1)

📄 Description

I don't really have a Windows system to test this with, but we have a CI failure on Windows because we build trust-dns-resolver with default-features = false:

   Compiling trust-dns-resolver v0.20.1
error[E0433]: failed to resolve: use of undeclared crate or module `ipconfig`
   --> C:\Users\runneradmin\.cargo\registry\src\github.com-1ecc6299db9ec823\trust-dns-resolver-0.20.1\src\error.rs:285:11
    |
285 | impl From<ipconfig::error::Error> for ResolveError {
    |           ^^^^^^^^ use of undeclared crate or module `ipconfig`

error[E0433]: failed to resolve: use of undeclared crate or module `ipconfig`
   --> C:\Users\runneradmin\.cargo\registry\src\github.com-1ecc6299db9ec823\trust-dns-resolver-0.20.1\src\error.rs:286:16
    |
286 |     fn from(e: ipconfig::error::Error) -> ResolveError {
    |                ^^^^^^^^ use of undeclared crate or module `ipconfig`

error: aborting due to 2 previous errors

For more information about this error, try `rustc --explain E0433`.
error: could not compile `trust-dns-resolver`

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/1431 **Author:** [@stephank](https://github.com/stephank) **Created:** 4/1/2021 **Status:** ✅ Merged **Merged:** 4/1/2021 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (1) - [`86820e4`](https://github.com/hickory-dns/hickory-dns/commit/86820e44318d079fec011b0a2a07fbaeb99e6119) Fix Windows build without system-config feature ### 📊 Changes **1 file changed** (+2 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `crates/resolver/src/error.rs` (+2 -1) </details> ### 📄 Description I don't really have a Windows system to test this with, but we have a [CI failure](https://github.com/portier/portier-broker/pull/211/checks?check_run_id=2243878215) on Windows because we build trust-dns-resolver with `default-features = false`: ``` Compiling trust-dns-resolver v0.20.1 error[E0433]: failed to resolve: use of undeclared crate or module `ipconfig` --> C:\Users\runneradmin\.cargo\registry\src\github.com-1ecc6299db9ec823\trust-dns-resolver-0.20.1\src\error.rs:285:11 | 285 | impl From<ipconfig::error::Error> for ResolveError { | ^^^^^^^^ use of undeclared crate or module `ipconfig` error[E0433]: failed to resolve: use of undeclared crate or module `ipconfig` --> C:\Users\runneradmin\.cargo\registry\src\github.com-1ecc6299db9ec823\trust-dns-resolver-0.20.1\src\error.rs:286:16 | 286 | fn from(e: ipconfig::error::Error) -> ResolveError { | ^^^^^^^^ use of undeclared crate or module `ipconfig` error: aborting due to 2 previous errors For more information about this error, try `rustc --explain E0433`. error: could not compile `trust-dns-resolver` ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>