[PR #2315] [MERGED] Allow to modify a RRSIG record before signing #2944

New issue

Closed

opened 2026-03-16 11:16:36 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:16:36 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2315
Author: @justahero
Created: 7/22/2024
Status: ✅ Merged
Merged: 7/24/2024
Merged by: @bluejekyll

Base: main ← Head: sz-modify-rrsig

📝 Commits (1)

044f339 Allow to modify a specific RRSIG record before signing

📊 Changes

2 files changed (+17 additions, -1 deletions)

View changed files

📝 conformance/packages/dns-test/src/record.rs (+8 -0)
📝 conformance/packages/dns-test/src/zone_file/mod.rs (+9 -1)

📄 Description

This PR adds support to modify a specific RRSIG record before starting a NameServer<Signed>.

An example on how to to use the logic in a conformance test.

let mut ns = NameServer::new(&dns_test::PEER, FQDN::ROOT, network)?.sign(settings)?;
ns.signed_zone_file_mut()
    .rrsig_mut(RecordType::SOA)
    .map(|rrsig| rrsig.signature_expiration = 21060207062816);
let ns = ns.start()?;

This is in preparation to set a timestamp (expiration, inception) to a value outside the supported range.

Builds upon #2316

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2315 **Author:** [@justahero](https://github.com/justahero) **Created:** 7/22/2024 **Status:** ✅ Merged **Merged:** 7/24/2024 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `main` ← **Head:** `sz-modify-rrsig` --- ### 📝 Commits (1) - [`044f339`](https://github.com/hickory-dns/hickory-dns/commit/044f3393233b377ed25ba223b1226910291eeaf5) Allow to modify a specific RRSIG record before signing ### 📊 Changes **2 files changed** (+17 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `conformance/packages/dns-test/src/record.rs` (+8 -0) 📝 `conformance/packages/dns-test/src/zone_file/mod.rs` (+9 -1) </details> ### 📄 Description This PR adds support to modify a specific RRSIG record before starting a `NameServer<Signed>`. An example on how to to use the logic in a conformance test. ```rust let mut ns = NameServer::new(&dns_test::PEER, FQDN::ROOT, network)?.sign(settings)?; ns.signed_zone_file_mut() .rrsig_mut(RecordType::SOA) .map(|rrsig| rrsig.signature_expiration = 21060207062816); let ns = ns.start()?; ``` This is in preparation to set a timestamp (expiration, inception) to a value outside the supported range. Builds upon #2316 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>